Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.alot: move to python-modules #31399

Closed
wants to merge 1 commit into from
Closed

pythonPackages.alot: move to python-modules #31399

wants to merge 1 commit into from

Conversation

xvapx
Copy link
Contributor

@xvapx xvapx commented Nov 8, 2017 •
edited by Profpatsch

Motivation for this change

To move pythonPackages.alot from python-packages.nix to python-modules.
#30929

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@garbas @Profpatsch

@xvapx xvapx requested a review from FRidh as a code owner November 8, 2017 16:29
@teto
Copy link
Member

teto commented Nov 9, 2017

I had started this here https://github.com/NixOS/nixpkgs/pull/30429/files . If you have nix+mac would be cool to test that one since it seems to be the blocking point.

@xvapx
Copy link
Contributor Author

xvapx commented Nov 9, 2017

Sorry, I don't have any mac.
Given that your PR updates the version and moves alot to pkgs, which seems to fit better, i will close this PR in favor of yours.

@xvapx xvapx closed this Nov 9, 2017
@xvapx xvapx deleted the alot branch February 21, 2018 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xvapx @teto @c0bw3b