Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CODEOWNERS: exclude lib/licenses.nix #31758

Merged
merged 1 commit into from Nov 23, 2017
Merged

CODEOWNERS: exclude lib/licenses.nix #31758

merged 1 commit into from Nov 23, 2017

Conversation

lukateras
Copy link
Member

@lukateras lukateras commented Nov 16, 2017 •
edited

Motivation for this change

See #31534 (comment).

Related: #31401, #31534, #31755, #31757.

/cc @c0bw3b

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 20, 2017 •
edited

Great! Thanks @yegortimoshenko

@Mic92 Mic92 merged commit 3db0f9d into NixOS:master Nov 23, 2017
@lukateras lukateras deleted the patch-10 branch December 18, 2017 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lukateras @c0bw3b @Mic92 @GrahamcOfBorg