Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

breakpad: 2016-03-28 -> 2017-11-13, resolve glibc 2.26 compat #31748

Closed
wants to merge 1 commit into from
Closed

breakpad: 2016-03-28 -> 2017-11-13, resolve glibc 2.26 compat #31748

wants to merge 1 commit into from

Conversation

lukateras
Copy link
Member

Motivation for this change

Alternative way to resolve breakpad compatibility (#31696), conflicts with #31746.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@lukateras
Copy link
Member Author

Oops, I guess the deletion has been already merged...

@abbradar
Copy link
Member

Ouch, I was faster >_>. Still, let's not leave an untested package in nixpkgs -- we have a lot of this dead weight now already.

@abbradar abbradar closed this Nov 16, 2017
@lukateras
Copy link
Member Author

OK.

@orivej orivej mentioned this pull request Nov 16, 2017
Closed
22 tasks
@lukateras lukateras deleted the breakpad/fix-glibc-2.26 branch December 18, 2017 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lukateras @abbradar