libmpack: fix darwin build #31759
Merged
libmpack: fix darwin build #31759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build libmpack luaPackages.mpack |
There was a problem hiding this comment.
Failure for system: x86_64-darwin
_lmpack_unpacker_new in lmpack-2d54d3.o
_lmpack_packer_new in lmpack-2d54d3.o
_lmpack_session_new in lmpack-2d54d3.o
...
ld: symbol(s) not found for architecture x86_64
clang-4.0: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [Makefile:117: mpack.so] Error 1
error: build of '/nix/store/yas2ybwc4d6k7dqqlyw12za2mzaxqj5z-lua5.2-lua-mpack-1.0.7_ef025224a799066b818120fb1f30a308543a6e99.drv' failed on ‘mac1’
builder for '/nix/store/yas2ybwc4d6k7dqqlyw12za2mzaxqj5z-lua5.2-lua-mpack-1.0.7_ef025224a799066b818120fb1f30a308543a6e99.drv' failed with exit code 2
error: build of ‘/nix/store/yas2ybwc4d6k7dqqlyw12za2mzaxqj5z-lua5.2-lua-mpack-1.0.7_ef025224a799066b818120fb1f30a308543a6e99.drv’ failed
There was a problem hiding this comment.
Success for system: x86_64-linux
mkdir -p "$out/lib/lua/5.2"
install -Dm755 mpack.so "$out/lib/lua/5.2/mpack.so"
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/1ly149a8iy8i7zb4jb7malpp027i315r-lua5.2-lua-mpack-1.0.7_ef025224a799066b818120fb1f30a308543a6e99
shrinking /nix/store/1ly149a8iy8i7zb4jb7malpp027i315r-lua5.2-lua-mpack-1.0.7_ef025224a799066b818120fb1f30a308543a6e99/lib/lua/5.2/mpack.so
stripping (with flags -S) in /nix/store/1ly149a8iy8i7zb4jb7malpp027i315r-lua5.2-lua-mpack-1.0.7_ef025224a799066b818120fb1f30a308543a6e99/lib
patching script interpreter paths in /nix/store/1ly149a8iy8i7zb4jb7malpp027i315r-lua5.2-lua-mpack-1.0.7_ef025224a799066b818120fb1f30a308543a6e99
checking for references to /tmp/nix-build-lua5.2-lua-mpack-1.0.7_ef025224a799066b818120fb1f30a308543a6e99.drv-0 in /nix/store/1ly149a8iy8i7zb4jb7malpp027i315r-lua5.2-lua-mpack-1.0.7_ef025224a799066b818120fb1f30a308543a6e99...
/nix/store/hf7smfj41jjb0sbzvp7ryjc0avw8dmas-libmpack-1.0.5
/nix/store/1ly149a8iy8i7zb4jb7malpp027i315r-lua5.2-lua-mpack-1.0.7_ef025224a799066b818120fb1f30a308543a6e99
LnL7
force-pushed
the
darwin-libmpack
branch
from
ec93be5
to
d6225a0
Compare
|
@GrahamcOfBorg build libmpack luaPackages.mpack |
There was a problem hiding this comment.
Success for system: x86_64-darwin
installing
install flags: install PREFIX=\$\(out\) LUA_LIBDIR=\$\(out\)/lib/lua/5.2 LUA_INC=-I/nix/store/qfvnm0phz11skqzr1kp4kl92567bqrah-lua-5.2.3/include CFLAGS=-llua USE_SYSTEM_LUA=yes USE_SYSTEM_MPACK=yes MPACK_LUA_VERSION=5.2.3 LUA_CMOD_INSTALLDIR=\$\$out/lib/lua/5.2
clang -shared -llua -I/usr/include/lua5.2 lmpack.c -o mpack.so -L/nix/store/j6sv33zmbxl143wh7a6jral3527vgiz0-libmpack-1.0.5/lib -lmpack
mkdir -p "$out/lib/lua/5.2"
install -Dm755 mpack.so "$out/lib/lua/5.2/mpack.so"
post-installation fixup
stripping (with flags -S) in /nix/store/0kivf60rd3jdv20b2lj32vw1nd1j1lfn-lua5.2-lua-mpack-1.0.7_ef025224a799066b818120fb1f30a308543a6e99/lib
patching script interpreter paths in /nix/store/0kivf60rd3jdv20b2lj32vw1nd1j1lfn-lua5.2-lua-mpack-1.0.7_ef025224a799066b818120fb1f30a308543a6e99
/nix/store/j6sv33zmbxl143wh7a6jral3527vgiz0-libmpack-1.0.5
/nix/store/0kivf60rd3jdv20b2lj32vw1nd1j1lfn-lua5.2-lua-mpack-1.0.7_ef025224a799066b818120fb1f30a308543a6e99
There was a problem hiding this comment.
Success for system: x86_64-linux
install -Dm755 mpack.so "$out/lib/lua/5.2/mpack.so"
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/85n2f4m9c9hyijw21x2k9njhg610dsgj-lua5.2-lua-mpack-1.0.7_ef025224a799066b818120fb1f30a308543a6e99
shrinking /nix/store/85n2f4m9c9hyijw21x2k9njhg610dsgj-lua5.2-lua-mpack-1.0.7_ef025224a799066b818120fb1f30a308543a6e99/lib/lua/5.2/mpack.so
stripping (with flags -S) in /nix/store/85n2f4m9c9hyijw21x2k9njhg610dsgj-lua5.2-lua-mpack-1.0.7_ef025224a799066b818120fb1f30a308543a6e99/lib
patching script interpreter paths in /nix/store/85n2f4m9c9hyijw21x2k9njhg610dsgj-lua5.2-lua-mpack-1.0.7_ef025224a799066b818120fb1f30a308543a6e99
checking for references to /tmp/nix-build-lua5.2-lua-mpack-1.0.7_ef025224a799066b818120fb1f30a308543a6e99.drv-0 in /nix/store/85n2f4m9c9hyijw21x2k9njhg610dsgj-lua5.2-lua-mpack-1.0.7_ef025224a799066b818120fb1f30a308543a6e99...
warning: SQLite database is busy
/nix/store/hf7smfj41jjb0sbzvp7ryjc0avw8dmas-libmpack-1.0.5
/nix/store/85n2f4m9c9hyijw21x2k9njhg610dsgj-lua5.2-lua-mpack-1.0.7_ef025224a799066b818120fb1f30a308543a6e99
|
needs to be (if lib.hasPrefix "luajit" lua.name then "CFLAGS=-lluajit-${lua.luaversion}" else "CFLAGS=-llua") |
On darwin we need the correct prefix during the buildPhase, otherwise the dynamic libraries have an incorrect install_name.
orivej
force-pushed
the
darwin-libmpack
branch
from
d6225a0
to
b7ed086
Compare
GrahamcOfBorg
added
10.rebuild-darwin: 11-100
10.rebuild-linux: 101-500
and removed
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
labels
|
@orivej mpack w/ luajit, and by extension neovim, are still broken as of that commit, with ld complaining that all the _lua_* symbols are not found |
|
@orivej Thanks! |
LnL7
commented
Nov 29, 2017
There was a problem hiding this comment.
@pikajude are you sure?
-- Installing: /nix/store/cg87wyq8rfd272dcph9z0569vx5avnvg-neovim-0.2.1/share/nvim/runtime/print/mac-roman.ps
-- Installing: /nix/store/cg87wyq8rfd272dcph9z0569vx5avnvg-neovim-0.2.1/share/nvim/runtime/print/prolog.ps
-- Installing: /nix/store/cg87wyq8rfd272dcph9z0569vx5avnvg-neovim-0.2.1/share/nvim/runtime/tutor/en/vim-01-beginner.tutor
-- Installing: /nix/store/cg87wyq8rfd272dcph9z0569vx5avnvg-neovim-0.2.1/share/nvim/runtime/tutor/tutor.tutor
post-installation fixup
gzipping man pages under /nix/store/cg87wyq8rfd272dcph9z0569vx5avnvg-neovim-0.2.1/share/man/
stripping (with flags -S) in /nix/store/cg87wyq8rfd272dcph9z0569vx5avnvg-neovim-0.2.1/bin
patching script interpreter paths in /nix/store/cg87wyq8rfd272dcph9z0569vx5avnvg-neovim-0.2.1
/nix/store/cg87wyq8rfd272dcph9z0569vx5avnvg-neovim-0.2.1/share/nvim/runtime/macros/less.sh: interpreter directive changed from "/bin/sh" to "/nix/store/i6xy9nh39wwzs048hh6fabb2fbqphvya-bash-4.4-p12/bin/sh"
/nix/store/cg87wyq8rfd272dcph9z0569vx5avnvg-neovim-0.2.1
|
@LnL7 what commit are you on? I just pulled and still get the ld error |
|
False alarm, my |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On darwin we need the correct prefix during the buildPhase, otherwise
the dynamic libraries have an incorrect install_name.
Motivation for this change
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)