Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mawk: 1.3.4-20161120 -> 1.3.4-20171017 #31239

Closed
wants to merge 1 commit into from
Closed

mawk: 1.3.4-20161120 -> 1.3.4-20171017 #31239

wants to merge 1 commit into from

Conversation

mimame
Copy link
Member

@mimame mimame commented Nov 4, 2017

Motivation for this change

Update mawk to the last version

20171017
+ add Debian compile/link flags to test-package.
+ cleanup spurious warnings from latest gcc.
+ changes for Original-Mawk #48:
+ add checks for stack overflow and underflow
+ increase stack limit to 1024
+ updated configure macros
+ update config.guess and config.sub

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

rycee
rycee reviewed Nov 4, 2017
View reviewed changes
pkgs/tools/text/mawk/default.nix Outdated
url = "ftp://invisible-island.net/mawk/${name}.tgz";
sha256 = "07hc33g2ip7463dravsiz0zwfc8vy4y4jxqvp7rz3hb896xw27in";
urls = [
"ftp://invisible-island.net/mawk/${name}.tgz"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ftp site seems super slow to me. Perhaps change the order of these so that the https site below comes first?

@mimame
Copy link
Member Author

mimame commented Nov 4, 2017

@rycee Thanks a lot for the advice. Fixed

@rycee
Copy link
Member

rycee commented Nov 4, 2017

Rebased to master in 9720703. Thanks!

@rycee rycee closed this Nov 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rycee rycee rycee left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mimame @rycee @GrahamcOfBorg