-
-
Notifications
You must be signed in to change notification settings - Fork 15.4k
statsd: repackage with node2nix #31235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(/cc @svanderburg ) |
currently running |
|
@Ma27 The Have you also tested the NixOS module that runs it as a service? I think you also need to update the package reference there and check whether the service still works. |
@svanderburg ah, didn't know about the module, will test it tonight :-) |
@svanderburg the I checked it using the following VM configuration from my branch: {
statsd = {
users.extraUsers.vm = {
isNormalUser = true;
password = "vm";
};
services.statsd.enable = true;
};
} The executable exists, the systemd services running on the default port (8125 in that case), the config defaults will be generated by the nixos module, it seems as nothing needs to be changed. |
@Ma27 Cool! I guess this issue is resolved then! |
@Ma27 I also just fixed the |
@Ma27 @svanderburg Is there a reason statsd backends were not included?
|
Could we add this packages to the list? |
@garbas sure, will do this on the weekend :) |
thank you, thank you, thank you! :) |
Motivation for this change
In #31032 it's attempted to get entirely rid of npm2nix.
One our packages which still used npm2nix is statsd.
Due to the fact that it's part of the NPM registry, it could be added to the
nodePackages
set.Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)