I tend to think that extracting constants for the sake of extracting constants is pointless and unneccesary. Everyone knows there are 24 hours in a day and 7 days in a week. There's little benefit in this change and its much more verbose.

This change came about because I noticed the SECONDS_PER_* and NANOSECONDS_PER_* calculations specify their operands inconsistently:

SECONDS_PER_HOUR = 60 * SECONDS_PER_MINUTE
NANOSECONDS_PER_MINUTE = NANOSECONDS_PER_SECOND * 60

So I wanted to fix that, and since I was changing the calculation anyway I thought why not make the calculation more understandable, since 60 can be seconds per minute or minutes per hour. It's a small ambiguity, but an ambiguity none the less.

We can make the constants private, if we don't want them in the API. Or I can remove the new constants and just fix the ordering of the operands to be consistent across the existing constants? Or we can abandon this change altogether if there's no interest?

The introduced constants are well known. Everyone knows how many hours are per day, or how many days are in a week. It's a bit more tricky to quickly remember the number of seconds in an hour, plus seeing 3600 is not immediately obvious that that's the meaning. Thank you, in any case!