graphite: override django and django_tagging #31254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of depending on specific versions in the django_tagging_0_4_3 and graphite_web derivations. This should fix: NixOS#30277 (comment) This was joint work of @basvandijk and @layus at NixCon 2017.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Instead of depending on a specific version of
djangoin thedjango_tagging_0_4_3andgraphite_webderivations we override the python package set in thegraphiteNixOS module.We do raise an error when
graphite_webanddjango_tagging_0_4_3are build with the incorrect versioned dependencies.@FRidh is this what you had in mind in: #30277 (comment)
This was joint work of @basvandijk and @layus at NixCon 2017.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)