Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixborg: reference implementation for upcoming RFC on hydra PR testing #31255

Closed
wants to merge 2 commits into from
Closed

nixborg: reference implementation for upcoming RFC on hydra PR testing #31255

wants to merge 2 commits into from
+250 −177

Conversation

globin
Copy link
Member

@globin globin commented Nov 4, 2017 •
edited
Loading

Motivation for this change

@nixborg consists of three seperate services:

  • nixborg: flask app to receive github hooks and fill a queue (currently redis, probably switching to rabbitmq in the future
  • nixborg-workers: workers consuming the queue, doing the git handling, commenting on github, HTTP requesting to nixbot-receiver
  • nixbot-receiver: stdlib-dependency-only python script to be run on hydra that calls out to hydra-update-jobset (PR for that cmdline utility upcoming on the hydra repository)

Code at: https://github.com/mayflower/nixborg (to be moved to the NixOS org if implementation is accepted)
PRs to see output: #30767, #30546
Hydra PR: NixOS/hydra#516
RFC upcoming

cc @edolstra, @grahamc, @fpletz, @7c6f434c, @LnL7, @dezgeg

@globin globin mentioned this pull request Nov 4, 2017
Closed
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 4, 2017
@gebner
Copy link
Member

gebner commented Nov 4, 2017

Is this bot related to @GrahamcOfBorg?

c0bw3b
c0bw3b reviewed Nov 4, 2017
View reviewed changes
nixos/modules/services/web-apps/nixborg.nix

githubSecret = mkOption {
type = types.str;
description = "The github webhook's secret key used for autheticating webhooks";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for authenticating webhooks

@FRidh FRidh added 6.topic: python 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS labels Nov 5, 2017
@edolstra
Copy link
Member

edolstra commented Nov 6, 2017

It would be better to put this in the nixborg repo and enable it via fetchGit.

@globin
Copy link
Member Author

globin commented Nov 6, 2017

Will do

@globin globin closed this Nov 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b

@orivej orivej

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@globin @gebner @edolstra @orivej @c0bw3b @FRidh @GrahamcOfBorg