Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fdm: 1.8 -> 1.9.0.20170124 #31238

Merged
merged 1 commit into from Nov 4, 2017
Merged

fdm: 1.8 -> 1.9.0.20170124 #31238

merged 1 commit into from Nov 4, 2017

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Nov 4, 2017

Motivation for this change

Version bump
and sf.net repo does not exist anymore so this updates homepage and src (part of #30636 )
and fetching a recent commit rather than plain v1.9 so we get these fixes :

cc @7c6f434c as maintainer : can you check I'm not messing up your update-walker process here?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@c0bw3b
Copy link
Contributor Author

c0bw3b commented Nov 4, 2017

By the way I tried building with and without NIX_CFLAGS_COMPILE = "-Dbool=int" and the build log were identical.

@7c6f434c
Copy link
Member

7c6f434c commented Nov 4, 2017 •
edited

Re: homepage change: let the evidence be here http://web.archive.org/web/20160314114153/https://sourceforge.net/projects/fdm/ (Arch, Suckless, Homebrew agree)

Re: using a fresher commit as release: OK, multiple use-after-free fixed sound like a good idea to include.

Re: versioning: I would call that 1.9.0.20170124 or maybe 1.9.0.20170124.cae4ea3. Rationale: future updates should make it clear which version is newer, and we cannot completely exclude 1.9.1 (although it is not too likely, I agree).

Re: flags: yes, this define was probably a quick fix for an old problem.

@c0bw3b c0bw3b changed the title fdm: 1.8 -> 1.9-cae4ea3 fdm: 1.8 -> 1.9.0.20170124 Nov 4, 2017
@c0bw3b
Copy link
Contributor Author

c0bw3b commented Nov 4, 2017

Done
I'm onboard with 1.9.0.20170124

@7c6f434c
Copy link
Member

7c6f434c commented Nov 4, 2017

Hm. Actually, since it looks like we want the freshest and not the releases, updateWalker=true; should be removed, because it is supposed to update to releases.

@c0bw3b
Copy link
Contributor Author

c0bw3b commented Nov 4, 2017

Indeed. I will correct that.

@c0bw3b
fdm: 1.8 -> 1.9.0.20170124
5fe398f 
sf.net repo does not exist anymore
@7c6f434c 7c6f434c merged commit cc3c38d into NixOS:master Nov 4, 2017
@c0bw3b c0bw3b deleted the pkg/fdm branch November 4, 2017 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@c0bw3b @7c6f434c @GrahamcOfBorg