nixpkgs manual : clearer meta.platforms description #31246
Merged
+3
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am unsure about linking specific lines, the file may change and we'd need to adjust the line numbers then. |
|
+1 on removing specific lines. This kind of adjustments tend to be forgotten. |
|
Thought about it and considered this particular file isn't going to change too often. I'm not against removing the line anchors. |
GrahamcOfBorg
added
10.rebuild-darwin: 0
|
I'd remove them, it'll become wrong and cause more PRs fixing the lines later on. Meanwhile, people familiar with platform names will (probably) have no trouble finding familiarity at the bottom of the file. |
Refer to doubles.nix for a list of common platforms types used in packages
c0bw3b
force-pushed
the
doc/meta-platforms
branch
from
ae6b171 to
4e892b9
Compare
|
Done deal. 🐈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Follow-up to #31217
Refer to
doubles.nixfor a list of common platforms types usually seen in package definitions@BlessJah @grahamc
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)