acl2: 6.5 -> 7.4; sbcl: remove 1.2.0 and 1.3.12 #31264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `make regression` line was failing because the expression was downloading a core-system-only, no-libraries source tarball. I switched to using fetchFromGitHub, which downloads the full source code -- the core system as well as the "community books", i.e. libraries -- but the libraries unfortunately do not build yet because they have more dependencies than the core system, and they also run into some impurity problems during the build process. This commit changes the ACL2 package so that at least the user will obtain the latest version of the core system, even though they won't get the community books. In a later commit I hope to fix this; it will require either changes to ACL2 itself, or a patch to be applied to ACL2 in nixpkgs. ACL2 7.4 has no trouble building on the current version of SBCL in nixpkgs, so I let it do so instead of using the ancient SBCL version 1.2.0 from 2014. I also added myself as a maintainer to this package, since I'm an active contributor to the ACL2 project and am interested in seeing it working on Nix.
SBCL 1.2.0 was being retained for the acl2 package, which no longer needs it. SBCL 1.3.12 was being retained for the maxima package, which appears to no longer need it.
|
Oh, I see @7c6f434c already closed it. Never mind then, I guess... :) |
|
Technically speaking, Maxima is not even affected. |
|
True - at least it seems that way. I thought maybe I was overlooking
something, since the comment does say that sbcl 1.3.12 is needed for
maxima. This is my first real pull request to nixpkgs so I thought I should
be careful.
2017/11/04 午後4:27 "Michael Raskin" <notifications@github.com>:
… Technically speaking, Maxima is not even affected.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#31264 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAqMWuR0YVKaqGFN91BC3Ctu6Y-K1-fRks5szPL_gaJpZM4QSMdI>
.
|
|
Your description for the pull request is definitely among the best-written ones… Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Short summary: ACL2 is out of date so I figured I should update it. Also removed some obsolete SBCL versions. See below for the long version.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)Note: execution of all binary files works equally well as the previous version did, though it could be improved -- the libraries are not installed, for example.
acl2: 6.5 -> 7.4, refactor
The
make regressionline was failing because the expression wasdownloading a core-system-only, no-libraries source tarball. I
switched to using fetchFromGitHub, which downloads the full source
code -- the core system as well as the "community books",
i.e. libraries -- but the libraries unfortunately do not build yet
because they have more dependencies than the core system, and they
also run into some impurity problems during the build process.
This commit changes the ACL2 package so that at least the user will
obtain the latest version of the core system, even though they won't
get the community books. In a later commit I hope to fix this; it
will require either changes to ACL2 itself, or a patch to be applied
to ACL2 in nixpkgs.
ACL2 7.4 has no trouble building on the current version of SBCL in
nixpkgs, so I let it do so instead of using the ancient SBCL version
1.2.0 from 2014.
I also added myself as a maintainer to this package, since I'm an
active contributor to the ACL2 project and am interested in seeing it
working on Nix.
sbcl: remove old versions 1.2.0, 1.3.12
SBCL 1.2.0 was being retained for the acl2 package, which no longer
needs it. SBCL 1.3.12 was being retained for the maxima package,
which appears to no longer need it.