Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ultrastardx: fix build #31251

Merged
merged 1 commit into from Nov 5, 2017
Merged

ultrastardx: fix build #31251

merged 1 commit into from Nov 5, 2017

Conversation

pbogdan
Copy link
Member

@pbogdan pbogdan commented Nov 4, 2017

Motivation for this change

Doesn't build, only supports ffmpeg up to 3.3 at the moment.

/cc @Profpatsch

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Profpatsch
Copy link
Member

Thanks.

@Profpatsch Profpatsch merged commit 14f232d into NixOS:master Nov 5, 2017
@pbogdan pbogdan deleted the ultrastardx-fix-build branch December 3, 2019 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pbogdan @Profpatsch @GrahamcOfBorg