linux.kernel: enable build of stk1160 modules #31364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dezgeg
reviewed
Nov 7, 2017
| @@ -573,6 +573,9 @@ with stdenv.lib; | |||
| ''} | |||
| MEDIA_USB_SUPPORT y | |||
| MEDIA_PCI_SUPPORT y | |||
| MEDIA_ANALOG_TV_SUPPORT y | |||
| VIDEO_STK1160_COMMON m | |||
| VIDEO_STK1160_AC97 y | |||
There was a problem hiding this comment.
Which kernel version has VIDEO_STK1160_AC97? I only see:
drivers/media/usb/Makefile:obj-$(CONFIG_VIDEO_STK1160) += stk1160/
drivers/media/usb/stk1160/Kconfig:config VIDEO_STK1160_COMMON
drivers/media/usb/stk1160/Kconfig:config VIDEO_STK1160
drivers/media/usb/stk1160/Kconfig: depends on VIDEO_STK1160_COMMON
drivers/media/usb/stk1160/Makefile:obj-$(CONFIG_VIDEO_STK1160) += stk1160.o
There was a problem hiding this comment.
4.9 kernel still has it (which i am using right now). It seems to have been removed with https://patchwork.linuxtv.org/patch/37808/ . according to https://cateee.net/lkddb/web-lkddb/VIDEO_STK1160_AC97.html it is available in "Linux kernels: 3.7–3.19, 4.0–4.10, 4.10+HEAD"
I will make this a conditional just like the other options which are only available in certain kernel versions
makefu
force-pushed
the
pkgs/linux.kernel/stk1160
branch
from
016ca50
to
7d6e839
Compare
|
@dezgeg i've added a conditional for the AC97 option. |
|
Ok, with that 4.4, 4.9 and latest kernels build. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Right now, for each new kernel or stdenv update i will have to build my own kernel with the stk1160 modules enabled (see http://cgit.euer.krebsco.de/stockholm/tree/makefu/2configs/hw/stk1160.nix ). This PR introduces the stk1160 module into the kernel configuration
Things done
nix-shell -p nox --run "nox-review wip"./result/bin/)