cvs: fix CVE-2017-12836 #31365
Merged
cvs: fix CVE-2017-12836 #31365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch is based on the work of the patch from Thorsten Glaser (MirBSD) [1] [1] http://www.mirbsd.org/cvs.cgi/src/gnu/usr.bin/cvs/src/rsh-client.c.diff?r1=1.6;r2=1.7
NeQuissimus
reviewed
Nov 7, 2017
| @@ -11,6 +11,7 @@ stdenv.mkDerivation { | |||
| patches = [ | |||
| ./getcwd-chroot.patch | |||
| ./CVE-2012-0804.patch | |||
| ./CVE-2017-12836.patch | |||
There was a problem hiding this comment.
Could we just fetchPatch it?
There was a problem hiding this comment.
No, unfortunately all the version I found (debian, MirBSD, OpenBSD,…) diverge a lot from our savannah based version 😞
There was a problem hiding this comment.
Also (our) upstream is kinda dead... we might want to consider using the debian version or extracing CVS from one of the *BSD CVSs'
There was a problem hiding this comment.
Ah, OK, let's merge this for now then
NeQuissimus
added
1.severity: security
10.rebuild-linux: 1-10
9.needs: port to stable
vcunat
added
8.has: port to stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is based on the work of the patch from Thorsten Glaser (MirBSD) [1]
[1] http://www.mirbsd.org/cvs.cgi/src/gnu/usr.bin/cvs/src/rsh-client.c.diff?r1=1.6;r2=1.7
Please consider backporting to stable.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)