Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lightgbm #31954

Closed
wants to merge 2 commits into from
Closed

Lightgbm #31954

wants to merge 2 commits into from

Conversation

teh
Copy link
Contributor

@teh teh commented Nov 22, 2017

Motivation for this change

New package + sha fix

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@teh teh requested a review from FRidh as a code owner November 22, 2017 23:04
@disassembler
Copy link
Member

@GrahamcOfBorg build pythonPackages.lightgbm

GrahamcOfBorg
GrahamcOfBorg reviewed Nov 23, 2017
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

warning: no files found matching '*.dll' under directory 'compile/windows/x64/DLL'
warning: no previously-included files matching '*.py[co]' found anywhere in distribution
writing manifest file 'lightgbm.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/qkfl8bq4v1n5c4rn574pknp7wjbqn6qs-python2.7-lightgbm-2.0.10

GrahamcOfBorg
GrahamcOfBorg reviewed Nov 23, 2017
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin



----------------------------------------------------------------------
Ran 8229 tests in 293.792s

FAILED (SKIP=67, failures=2)
builder for '/nix/store/rizb40ymf5d6gdahcx88bkv6rv90f2iq-python2.7-scikit-learn-0.19.1.drv' failed with exit code 1
error: build of '/nix/store/rizb40ymf5d6gdahcx88bkv6rv90f2iq-python2.7-scikit-learn-0.19.1.drv' failed on ‘mac1’
cannot build derivation ‘/nix/store/hpnmg6g0xw45cn5q8asrpzg7dqjxj67w-python2.7-lightgbm-2.0.10.drv’: 1 dependencies couldn't be built
error: build of ‘/nix/store/hpnmg6g0xw45cn5q8asrpzg7dqjxj67w-python2.7-lightgbm-2.0.10.drv’ failed

@FRidh
Copy link
Member

FRidh commented Nov 23, 2017

sha was fixed in #31951?

FRidh
FRidh requested changes Nov 23, 2017
View reviewed changes
pkgs/development/python-modules/lightgbm/default.nix
buildInputs = [
cmake
];

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

Ran 0 tests in 0.000s

No tests are found. Either the test runner cannot find tests and needs to be patched, or there simply are no tests in which case the tests need to be disabled. Do include a comment explaining why the tests are disabled.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disabled tests and added a comment. The tests don't seem to be included in the pypi distribution. We could build from GitHub if we want the tests?

@xeji
Copy link
Contributor

xeji commented Aug 1, 2018

@GrahamcOfBorg build python36Packages.lightgbm python27Packages.lightgbm

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: python36Packages.lightgbm, python27Packages.lightgbm

Partial log (click to expand)

    cmd_obj.run()
  File "setup.py", line 162, in run
    compile_cpp(use_mingw=self.mingw, use_gpu=self.gpu)
  File "setup.py", line 128, in compile_cpp
    silent_call(cmake_cmd, raise_error=True, error_msg='Please install CMake first')
  File "setup.py", line 73, in silent_call
    raise Exception(error_msg)
Exception: Please install CMake first
builder for '/nix/store/7zdfs7zy4mjvgarw5vrd4rx1vak3zv8l-python3.6-lightgbm-2.0.10.drv' failed with exit code 1
error: build of '/nix/store/7zdfs7zy4mjvgarw5vrd4rx1vak3zv8l-python3.6-lightgbm-2.0.10.drv', '/nix/store/j99jvk1xv5whd5i2w32p03185gadwxky-python2.7-lightgbm-2.0.10.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python36Packages.lightgbm, python27Packages.lightgbm

Partial log (click to expand)

/build/lightgbm-2.0.10
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/lv09c56h365lli9zj75b41isqmxa2rg6-python3.6-lightgbm-2.0.10
shrinking /nix/store/lv09c56h365lli9zj75b41isqmxa2rg6-python3.6-lightgbm-2.0.10/lib/python3.6/site-packages/lightgbm/lib_lightgbm.so
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/lv09c56h365lli9zj75b41isqmxa2rg6-python3.6-lightgbm-2.0.10/lib
patching script interpreter paths in /nix/store/lv09c56h365lli9zj75b41isqmxa2rg6-python3.6-lightgbm-2.0.10
checking for references to /build in /nix/store/lv09c56h365lli9zj75b41isqmxa2rg6-python3.6-lightgbm-2.0.10...
/nix/store/lv09c56h365lli9zj75b41isqmxa2rg6-python3.6-lightgbm-2.0.10
/nix/store/7w5zyac26d3bzccm2jlyf3hlc1pr0fdc-python2.7-lightgbm-2.0.10

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python36Packages.lightgbm, python27Packages.lightgbm

Partial log (click to expand)

/build/lightgbm-2.0.10
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/7c746j035f7wgc03bk9v33ps2akfcq5f-python3.6-lightgbm-2.0.10
shrinking /nix/store/7c746j035f7wgc03bk9v33ps2akfcq5f-python3.6-lightgbm-2.0.10/lib/python3.6/site-packages/lightgbm/lib_lightgbm.so
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/7c746j035f7wgc03bk9v33ps2akfcq5f-python3.6-lightgbm-2.0.10/lib
patching script interpreter paths in /nix/store/7c746j035f7wgc03bk9v33ps2akfcq5f-python3.6-lightgbm-2.0.10
checking for references to /build in /nix/store/7c746j035f7wgc03bk9v33ps2akfcq5f-python3.6-lightgbm-2.0.10...
/nix/store/7c746j035f7wgc03bk9v33ps2akfcq5f-python3.6-lightgbm-2.0.10
/nix/store/hl9z7cxxpv4rc6jzv8hms3b1qw4xr0gr-python2.7-lightgbm-2.0.10

@costrouc costrouc mentioned this pull request Jul 11, 2019
Merged
10 tasks
@mmahut
Copy link
Member

mmahut commented Aug 11, 2019

Are there any updates on this pull request, please?

@teh
Copy link
Contributor Author

teh commented Aug 11, 2019

@mmahut I'm carrying this around in my own overlay. Might be easiest if you create a new PR if you want this included in nixpkgs itself? Happy to review that. Going to close this branch as it's way old.

@teh teh closed this Aug 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrahamcOfBorg GrahamcOfBorg GrahamcOfBorg left review comments

@FRidh FRidh FRidh requested changes

Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@teh @disassembler @FRidh @xeji @GrahamcOfBorg @mmahut @veprbl @matthewbauer