Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simgrid: 3.13 -> 3.17 clean and add options #31963

Closed
wants to merge 0 commits into from
Closed

simgrid: 3.13 -> 3.17 clean and add options #31963

wants to merge 0 commits into from

Conversation

mickours
Copy link
Contributor

@mickours mickours commented Nov 23, 2017 •
edited

Motivation for this change

This package was outdated

Things done

I cleaned the unnecessary piece of code.

I've update to the latest stable version.

I make the checks pass.

Also I've added some optional support for fotran, Java, modelChecking and debugging

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip" No packages that depends on this
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@peti
Copy link
Member

peti commented Nov 23, 2017

2,050 changes files? I'm pretty sure that's not what you intended with this PR.

peti
peti requested changes Nov 23, 2017
View reviewed changes
Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this PR wasn't created frommaster.

@Mic92
Copy link
Member

Mic92 commented Nov 23, 2017 •
edited

Assuming that origin is your fork remote, you can fix this with the following commands:

git remote add upstream https://github.com/NixOS/nixpkgs
git fetch upstream master
git rebase --onto upstream/master HEAD~5 HEAD
git branch -D update-simgrid
git checkout -b update-simgrid
git push origin --force update-simgrid

@mickours mickours closed this Nov 23, 2017
@mickours mickours deleted the update-simgrid branch November 27, 2017 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti peti requested changes

@edolstra edolstra Awaiting requested review from edolstra

@edwtjo edwtjo Awaiting requested review from edwtjo

@FRidh FRidh Awaiting requested review from FRidh

@nbp nbp Awaiting requested review from nbp

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mickours @peti @Mic92