inconsolata: 1.010 -> inherit google-fonts #31960
Conversation
| repo = "fonts"; | ||
| rev = "4c3e95c802f8f12b78869ff50d552014de63f9c1"; | ||
| sha256 = "1ndmsf4c0k36dakmps0vr7hhg5ss8m7ywja7v55xdrinvli58v2f"; | ||
| }; |
There was a problem hiding this comment.
We have a package called google-fonts. Maybe we can take the source/version from there?
inherit (google-fonts) src version;
Do we need a dedicated inconsolata font package then at all?
There was a problem hiding this comment.
Oh, I missed it. I think that it's nice to have the individual package regarding backward compatibility and package size. (google-fonts is bigger than the individual package.) If it's complicated to maintain an individual package, there is another method that split google-fonts into multiple packages (e.g., google-fonts: install all fonts, google-fonts-foobar: install foobar font only).
To be honest, I don't know whatever method is optimal.
mikoim
changed the title
|
For the time being, inherit source and version from google-fonts. |
|
I'm trying to find out why my fonts look garbage after my latest update to the unstable channel.... perhaps it was this. I will try to revert and report back. |
|
@jb55 Sorry for the inconvenience. What issue happened in your environment? |
Motivation for this change
The upstream moved to Google fonts repository on GitHub.
Things done
build-use-sandboxinnix.confon non-NixOS)Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)nix-shell -p nox --run "nox-review wip"Tested execution of all binary files (usually in./result/bin/)