ricty: init at 4.1.0 #31967
Merged
ricty: init at 4.1.0 #31967
+40
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Nov 23, 2017
| buildInputs = [ google-fonts migu fontforge which ]; | ||
|
|
||
| buildPhase = '' | ||
| inconsolata=${google-fonts} migu=${migu} ./ricty_generator.sh auto |
There was a problem hiding this comment.
Since this build takes external buildInputs, that might be updated. We cannot use outputHash. Otherwise the package would break, whenever somebody updates google-fonts.
There was a problem hiding this comment.
After all this is only a performance optimization for large font packages.
There was a problem hiding this comment.
Thank you. I misunderstood that.
Mic92
reviewed
Nov 23, 2017
pkgs/data/fonts/ricty/default.nix
Outdated
| install -m644 --target $out/share/fonts/truetype/ricty -D Ricty-*.ttf | ||
| ''; | ||
|
|
||
| preferLocalBuild = true; |
There was a problem hiding this comment.
license.unfree already disable hydra builds.
|
@GrahamcOfBorg eval |
|
rebased and fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Ricty is Japanese font for coding and programming.
This PR depends on #31966.
Things done
build-use-sandboxinnix.confon non-NixOS)Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)nix-shell -p nox --run "nox-review wip"Tested execution of all binary files (usually in./result/bin/)