Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ninja: 1.7.2 -> 1.8.2 #31796

Merged
merged 1 commit into from Nov 18, 2017
Merged

ninja: 1.7.2 -> 1.8.2 #31796

merged 1 commit into from Nov 18, 2017

Conversation

robertodr
Copy link
Contributor

Motivation for this change

Updates Ninja to its latest version, released Sep 13

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@orivej orivej changed the base branch from master to staging November 18, 2017 18:27
@orivej orivej changed the base branch from staging to master November 18, 2017 18:28
@orivej orivej changed the base branch from master to staging November 18, 2017 18:57
Copy link
Contributor

@orivej orivej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the build phase and added installation of bash and zsh completions.

@robertodr
Copy link
Contributor Author

@orivej Great! Thank you!

@Mic92
Copy link
Member

Mic92 commented Nov 18, 2017

@GrahamcOfBorg build ninja

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-darwin

[27/28] CXX build/ninja.o
[28/28] LINK ninja
bootstrapping ninja...
wrote build.ninja.
bootstrap complete.  rebuilding...
installing
post-installation fixup
stripping (with flags -S) in /nix/store/2lkgqpmz3k3w4vk3n9c0lm8fnajk973v-ninja-1.8.2/bin 
patching script interpreter paths in /nix/store/2lkgqpmz3k3w4vk3n9c0lm8fnajk973v-ninja-1.8.2
/nix/store/2lkgqpmz3k3w4vk3n9c0lm8fnajk973v-ninja-1.8.2

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

wrote build.ninja.
bootstrap complete.  rebuilding...
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/m7w3pdw93zya77lkph139545vnpifdxy-ninja-1.8.2
shrinking /nix/store/m7w3pdw93zya77lkph139545vnpifdxy-ninja-1.8.2/bin/ninja
stripping (with flags -S) in /nix/store/m7w3pdw93zya77lkph139545vnpifdxy-ninja-1.8.2/bin 
patching script interpreter paths in /nix/store/m7w3pdw93zya77lkph139545vnpifdxy-ninja-1.8.2
checking for references to /tmp/nix-build-ninja-1.8.2.drv-0 in /nix/store/m7w3pdw93zya77lkph139545vnpifdxy-ninja-1.8.2...
/nix/store/m7w3pdw93zya77lkph139545vnpifdxy-ninja-1.8.2

@Mic92 Mic92 merged commit d4d7e1e into NixOS:staging Nov 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants