Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git: honor $PATH for sendmail used in git-send-email command #31788

Merged
merged 1 commit into from Nov 18, 2017
Merged

git: honor $PATH for sendmail used in git-send-email command #31788

merged 1 commit into from Nov 18, 2017

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Nov 18, 2017

git-send-email will now search $PATH for a sendmail binary, instead of
the (previously fixed) list of paths.

Motivation for this change

This facilates out of the box usage in combination with sendmail-compatible binaries in $PATH.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@flokli
git: honor $PATH for sendmail used in git-send-email command
e4bf9e4 
git-send-email will now search $PATH for a sendmail binary, instead of
the (previously fixed) list of paths.
bjornfor
bjornfor approved these changes Nov 18, 2017
View reviewed changes
Copy link
Contributor

@bjornfor bjornfor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be interesting to see what upstream thinks of this patch. (I've wanted to do this change myself, but never prioritized it high enough.)

@orivej orivej changed the base branch from master to staging November 18, 2017 09:39
orivej
orivej approved these changes Nov 18, 2017
View reviewed changes
Copy link
Contributor

@orivej orivej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vcunat If the current staging will have to be rebuilt another time, let's include this.

@vcunat vcunat merged commit e4bf9e4 into NixOS:staging Nov 18, 2017
vcunat added a commit that referenced this pull request Nov 18, 2017
@vcunat
Merge #31788: git: honor $PATH for sendmail...
d62531d
@vcunat
Copy link
Member

vcunat commented Nov 18, 2017

It's not that big, actually, so pushing immediately.

Estimating rebuild amount by counting changed Hydra jobs.
    336 x86_64-darwin
    578 x86_64-linux

@flokli
Copy link
Contributor Author

flokli commented Nov 18, 2017

@bjornfor Patch sent to upstream :-)

@flokli flokli deleted the git-send-email-sendmail branch November 18, 2017 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orivej orivej orivej approved these changes

@bjornfor bjornfor bjornfor approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@flokli @vcunat @orivej @bjornfor @GrahamcOfBorg