Unextracted all cabal hashes #31333
Unextracted all cabal hashes #31333
Conversation
|
cc: @shlevy |
|
Barring objections from @peti, ping me in a few days and I'll merge |
| in fetchFromGitHub (src-spec // | ||
| { postFetch = "${partition-all-cabal-hashes}/bin/partition-all-cabal-hashes $downloadedFile $out"; | ||
| }) | ||
| fetchurl { |
There was a problem hiding this comment.
Why did you prefer fetchurl over fetchFromGitHub here?
There was a problem hiding this comment.
fetchFromGitHub is the whole cause of the problem. It extracts the tarball in full to a directory, which breaks on macOS when that tarball has paths that clash on a case insensitive file system.
There was a problem hiding this comment.
Ah, I got it! This whole ordeal does make sense now :D
|
Should we remove that extra hook from fetchurl / fetchgit too? |
|
@shlevy Any chance we can get this back ported to 17.03? |
|
Sure, ping me on the PR |
|
@shlevy Should I just open a PR to the 17.03 branch on nixpkgs-channels? |
|
No, the release-17.03 branch here. |
|
Gotcha. |
Motivation for this change
#30290, while useful, is kind of massively complicated, and actually leads to hashes which are different depending on the OS. We can get rid of the crazy C program and special schema, and reduce disk usage if we just leave all the files in the tarball and extract them as needed to their own store paths. This produces unique derivations and therefore unique paths, even given macOS's case insensitivity, without having to conjure those paths manually.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)