Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dns-root-data: 2017-08-29 -> 2017-10-24 #31331

Merged
merged 1 commit into from Nov 7, 2017
Merged

dns-root-data: 2017-08-29 -> 2017-10-24 #31331

merged 1 commit into from Nov 7, 2017

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Nov 6, 2017

Motivation for this change

The hash is wrong due to upstream update.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

This causes a large rebuild; is it massive?

@Mic92: you mentioned in #28964 that there are ways to prevent the hash from becoming outdated; do you have some specific hints?

@vcunat
Copy link
Member

vcunat commented Nov 6, 2017

The contents has changed – B changed its A record roughly two weeks ago. Mic92 suggested us mirroring it and fetching a fixed version.

@vcunat
Copy link
Member

vcunat commented Nov 6, 2017

But practically we do get the contents mirrored – in the binary cache – I'm still getting it substituted...

@vcunat vcunat added 1.severity: mass-rebuild 9.needs: port to stable A PR needs a backport to the stable release. labels Nov 6, 2017
@vcunat vcunat self-assigned this Nov 7, 2017
vcunat added a commit that referenced this pull request Nov 7, 2017
@vcunat
Merge #31331: dns-root-data: 2017-08-29 -> 2017-10-24
30c971e
@vcunat
Copy link
Member

vcunat commented Nov 7, 2017

Staged.

@vcunat vcunat merged commit f35f995 into NixOS:master Nov 7, 2017
@knedlsepp
Copy link
Member

@vcunat: dns-root-data changed again a few days ago. I think the problem with the binary cache is that this doesn't properly work for nix-stores some place else than "/nix/store" (which is the case for my custom HPC install), as the install prefix is somehow used in computing the hash for the store path.
Can this be circumvented somehow so $HOME/nix/store stores can also make use of the binary cache for this kind of data?

@knedlsepp knedlsepp mentioned this pull request Nov 20, 2017
Closed
8 tasks
@vcunat
Copy link
Member

vcunat commented Nov 20, 2017

Binaries for different prefix are different, because the absolute paths are often hardcoded in the executables and elsewhere. You can circumvent this, e.g. see https://nixos.wiki/wiki/Nix_Installation_Guide#Installing_without_root_permissions

@knedlsepp
Copy link
Member

knedlsepp commented Nov 20, 2017 •
edited

While I understand that the scheme makes sense for binaries, I think for fixed-output derivations it is actually rather odd and prevents reuse of the binary cache.

@vcunat
Copy link
Member

vcunat commented Nov 20, 2017

Right, I think even self-references aren't allowed there.

@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
@vbgl vbgl deleted the dns-root-data-20171024 branch May 22, 2019 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees

@vcunat vcunat

Labels
1.severity: mass-rebuild
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vbgl @vcunat @knedlsepp @samueldr