Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i3lock-color: limit to i686 and x86-64 platforms #31323

Merged
merged 1 commit into from Nov 7, 2017

Conversation

rycee
Copy link
Member

@rycee rycee commented Nov 6, 2017

Motivation for this change

Compilation fails for other CPU architectures due to requiring the
SSE2 instruction set. See Raymo111/i3lock-color#44 for upstream issue.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Compilation fails for other CPU architectures due to requiring the
SSE2 instruction set. See [1] for upstream issue.

[1]: Raymo111/i3lock-color#44
@rycee rycee requested a review from garbas November 6, 2017 16:58
@NeQuissimus NeQuissimus merged commit 2e333a2 into NixOS:master Nov 7, 2017
@rycee rycee deleted the i3lock-color-needs-sse2 branch November 7, 2017 13:38
@PandorasFox
Copy link

You should be able to un-limit this. I properly include-guarded some stuff now.

@rycee
Copy link
Member Author

rycee commented Dec 11, 2017

@PandorasFox From what I can tell the change hasn't been in a tagged release. I think we have to wait with the packaging until such a release is available. Thanks a lot for the heads up, though!

@PandorasFox
Copy link

Ahhh, yeah. I'm giving it a week or so to make sure there's no bugs before I make another release tarball, since I won't be able to fix anything during my finals next week.

@rycee
Copy link
Member Author

rycee commented Dec 11, 2017

No worries :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants