nixopsUnstable: don't depend on external URLs #31869
Conversation
|
I've just pushed another impurity fix: NixOS/nixops@f1ffb53 |
|
There seem to be many more: https://gist.github.com/2f8f115d4737b00a2a2dc36706002f02 |
|
@basvandijk needs nixops bump, otherwise +1 :) |
Instead of downloading a tarball from https://static.domenkozar.com we build the tarball ourself by downloading nixops's source code from GitHub and importing the release.nix file.
basvandijk
force-pushed
the
nixopsUnstable-refactor
branch
from
370b23a
to
96b243b
Compare
|
@domenkozar good stuff on the impurity fixes. I bumped nixops. |
| version = "2017-05-22"; | ||
| src = fetchurl { | ||
| # Sadly hydra doesn't offer download links | ||
| url = "https://static.domenkozar.com/nixops-1.5.1pre2169_8f4a67c.tar.bz2"; |
|
I didn't chose this path because it uses import-from-derivation, will this work on Hydra? |
|
Hi Domen, is import-from-derivation frowned upon? Why wouldn't this work on hydra? Note that the following works |
|
In Nix 1.12, there is It's because it makes the evaluator build, defeating the purpose of evaluation/build separation and making the whole process happen in one bang on the Hydra master. |
|
Maybe I can partially answer my own question: hydra separates Nix evaluation from building (i.e. |
|
I just noticed your answer. Thanks. That's a bummer though. It means we can't easily upgrade nixopsUnstable. |
|
Actuall we can, since Hydra got support of serving S3 files. https://hydra.nixos.org/build/64518294 -> https://hydra.nixos.org/build/64518294/download/2/nixops-1.6pre2276_9203440.tar.bz2 |
|
Sweet! Then I'll close this PR and we can create a new one based on the tarball on hydra. |
Motivation for this change
Upgrading
nixopsUnstableis currently difficult because you have to generate a tarball, put it somewhere online and point the derivation to it (for example we currently usehttps://static.domenkozar.com/nixops-1.5.1pre2169_8f4a67c.tar.bz2).Ideally, we only have to specify a git revision and sha256.
Things done
Instead of downloading a tarball from an external URL we build the tarball ourself by downloading nixops's source code from GitHub and importing the release.nix file.
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)@domenkozar ping.