Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kde-frameworks: 5.39 -> 5.40 #31654

Merged
merged 1 commit into from Nov 17, 2017
Merged

kde-frameworks: 5.39 -> 5.40 #31654

merged 1 commit into from Nov 17, 2017

Conversation

bkchr
Copy link
Contributor

@bkchr bkchr commented Nov 14, 2017 •
edited

Motivation for this change

Regular update.

@ttuegel @peterhoeg @adisbladis

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@peterhoeg
Copy link
Member

I'm currently running nix-build nixos/tests/plasma5.nix against this.

@bkchr
Copy link
Contributor Author

bkchr commented Nov 14, 2017

nox-review does not work for me. :( I just build it for my system.

@bkchr
Copy link
Contributor Author

bkchr commented Nov 15, 2017

@peterhoeg did you found any problems?

@peterhoeg
Copy link
Member

peterhoeg commented Nov 15, 2017 via email

@disassembler
Copy link
Member

If @peterhoeg approves the changes, this should be rebased on staging because of the number of rebuilds it causes.

@peterhoeg
Copy link
Member

nox-review is still failing here. I'll take a look tomorrow.

@bkchr
Copy link
Contributor Author

bkchr commented Nov 16, 2017

I will push fixes for other packages that are affected by these changes to this pull request. After everything works, I will create new pull requests for these packages.

@bkchr
Copy link
Contributor Author

bkchr commented Nov 16, 2017 •
edited

Hmm, having again problems with digikam that it can not find gitversion.h

Edit:
Building digikam with nix-build and not nox-review circumvents the problem...

@bkchr bkchr mentioned this pull request Nov 16, 2017
Merged
8 tasks
@bkchr
Copy link
Contributor Author

bkchr commented Nov 16, 2017

Created a new pr for heaptrack: #31756

Nox-review worked now for me (building digikam 'manual' (nix-build))

@adisbladis
Copy link
Member

nox-review passes and KDE is working fine :) 👍

@peterhoeg
Copy link
Member

Please try to run nix-build nixos/tests/plasma5.nix

@adisbladis
Copy link
Member

@peterhoeg The tests are passing.

@orivej orivej merged commit 61090c8 into NixOS:master Nov 17, 2017
@orivej
Copy link
Contributor

orivej commented Nov 17, 2017

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

Assignees
No one assigned
Labels
6.topic: qt/kde 8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@bkchr @peterhoeg @disassembler @adisbladis @orivej @c0bw3b @GrahamcOfBorg