Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-sdk-cpp: fix on darwin #31650

Merged
merged 1 commit into from
Feb 17, 2018
Merged

aws-sdk-cpp: fix on darwin #31650

merged 1 commit into from
Feb 17, 2018
+6 −1

Conversation

matthewbauer
Copy link
Member

Motivation for this change

This resolves the issues on macOS. Not sure why these frameworks are needed?

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 14, 2017
copumpkin
copumpkin reviewed Nov 15, 2017
View reviewed changes
pkgs/development/libraries/aws-sdk-cpp/default.nix Outdated
buildInputs = [ cmake curl ];
buildInputs = [ cmake curl ]
++ lib.optionals stdenv.isDarwin
(with darwin.apple_sdk.frameworks; [ CoreAudio AudioToolbox ]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose we could do this, or just conditionally disable those SDKs. I think it's for Amazon Lex and Polly or something like that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably avoid depending on frameworks for this, since it's a dependency of nix.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that was my concern, although Nix only builds the S3 subset of the SDK (so we could perhaps only enable the frameworks if someone wants all sub-SDKs)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's aws-sdk-cpp.override { apis = ["text-to-speach"]; } that needs the frameworks.

@LnL7 LnL7 added the 6.topic: darwin Running or building packages on Darwin label Nov 16, 2017
@matthewbauer
aws-sdk-cpp: fix on darwin

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: 91BE884FBA4B591A
Learn about vigilant mode
590cdf0
@matthewbauer matthewbauer force-pushed the aws-sdk-cpp-darwin-fix branch from 2656fb1 to 590cdf0 Compare February 17, 2018 16:02
@GrahamcOfBorg GrahamcOfBorg removed the 6.topic: darwin Running or building packages on Darwin label Feb 17, 2018
@matthewbauer
Copy link
Member Author

/cc @LnL7 Added a check for text-to-speech. It should be ready to merge now.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)


  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100  220k  100  220k    0     0   525k      0 --:--:-- --:--:-- --:--:--  525k

fetching path ‘/nix/store/mzfjiwjw21sd33j7456bdyci3zhs167w-aws-sdk-cpp-1.3.22’...

*** Downloading ‘https://cache.nixos.org/nar/1djac7lrqr6fxdxnagq9flyd04fj94yhkvyl43n61vsa2fvgnp1g.nar.xz’ (signed by ‘cache.nixos.org-1’) to ‘/nix/store/mzfjiwjw21sd33j7456bdyci3zhs167w-aws-sdk-cpp-1.3.22’...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  1 17.1M    1  219k    0     0   490k      0  0:00:35 --:--:--  0:00:35  489k
 62 17.1M   62 10.6M    0     0  7117k      0  0:00:02  0:00:01  0:00:01 7112k
100 17.1M  100 17.1M    0     0  8020k      0  0:00:02  0:00:02 --:--:-- 8020k

/nix/store/mzfjiwjw21sd33j7456bdyci3zhs167w-aws-sdk-cpp-1.3.22

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

these paths will be fetched (15.21 MiB download, 193.20 MiB unpacked):
  /nix/store/sj222minlg7xss9wnc9k798f2y6hmbya-aws-sdk-cpp-1.3.22
copying path '/nix/store/sj222minlg7xss9wnc9k798f2y6hmbya-aws-sdk-cpp-1.3.22' from 'https://cache.nixos.org'...
/nix/store/sj222minlg7xss9wnc9k798f2y6hmbya-aws-sdk-cpp-1.3.22

@LnL7 LnL7 merged commit 2e33da9 into NixOS:master Feb 17, 2018
@matthewbauer matthewbauer deleted the aws-sdk-cpp-darwin-fix branch February 22, 2019 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@copumpkin copumpkin

@LnL7 LnL7

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@matthewbauer @GrahamcOfBorg @copumpkin @LnL7