nixos-option: don't eval description #31656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(/cc @grahamc) |
|
I tested this using the following command: |
|
What the… does anybody know why the description was eval'ed in nixos-option? |
fpletz
approved these changes
Nov 14, 2017
|
this is basically what I thought last night, however I was unsure if there are any historical reasons for this, so I delivered it in a separate PR to discuss about this:)
… On 14. Nov 2017, at 12:29 PM, Franz Pletz ***@***.***> wrote:
@fpletz approved this pull request.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
@nbp I'm going to merge this in 12 hours unless I hear otherwise from you :) |
nbp
approved these changes
Nov 14, 2017
|
@grahamc Thanks for the heads-up, next time give me more than 12h, I barely got time to check my personal emails these days. |
|
Can do :) thank you for the look. I’ll give you 24 next! ;)
…On Tue 14. Nov 2017 at 17:06, Nicolas B. Pierron ***@***.***> wrote:
Merged #31656 <#31656>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#31656 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAErrAYuUq2l9gjbkaVBLu7lNwCaQLwIks5s2g78gaJpZM4QdL1P>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
see #31630 (comment)
When backticks are used in a description field of a nixos-option, the value inside a backtick will be evaluated which can cause unexpected side-effects.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)