Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This reverts commit f90f660. This broke Hydra's release.nix, which contained preCheck = ''export LOGNAME=${LOGNAME:-foo}'';
- Loading branch information
Showing
3 changed files
with
3 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,7 @@ | ||
[ | ||
[ x:x | ||
https://svn.cs.uu.nl:12443/repos/trace/trunk | ||
http://www2.mplayerhq.hu/MPlayer/releases/fonts/font-arial-iso-8859-1.tar.bz2 | ||
http://losser.st-lab.cs.uu.nl/~armijn/.nix/gcc-3.3.4-static-nix.tar.gz | ||
http://fpdownload.macromedia.com/get/shockwave/flash/english/linux/7.0r25/install_flash_player_7_linux.tar.gz | ||
ftp://ftp.gtk.org/pub/gtk/v1.2/gtk+-1.2.10.tar.gz | ||
channel:nixos-17.09 | ||
] |
2c39e4e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2c39e4e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how is that snippet from Hydra's release nix even valid? Isn't the `${} parsed as a Nix substitution, but the thing after the colon looks like a shell-ism?
2c39e4e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:-D surprise
In any case, it would be better to fix such occurrences, as they worked purely by chance (i.e. the meaning is not URI/URL at all).
2c39e4e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally think that 1.11 -> 1.12 could contain this kind of "regression" (documented in release notes).