Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keybase-bin: init at 1.0.35-20171110170110.68245d46b #31651

Closed
wants to merge 1 commit into from
Closed

keybase-bin: init at 1.0.35-20171110170110.68245d46b #31651

wants to merge 1 commit into from

Conversation

np
Copy link
Contributor

@np np commented Nov 14, 2017

Motivation for this change

While we have already keybase-gui this package is easier to keep in sync with upstream. Moreover upstream make releases frequently.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@peterhoeg
Copy link
Member

But we are already building the various components that make up this from source. What exactly do we gain by going this route?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@np @peterhoeg @matthewbauer @GrahamcOfBorg