Repackage everything with node2nix #31655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
started |
|
Ok so how does this reduce the LOC by 60,000? |
Ma27
commented
Nov 14, 2017
| chmod +x $out/bin/airfield | ||
| wrapProgram $out/bin/airfield \ | ||
| --set NODE_PATH "${runtimeEnv}/lib/node_modules" | ||
| ''; | ||
|
|
||
| meta = { |
|
@grahamc since I dropped the last remaining references of npm2nix this ancient package set could finally be removed. |
Ma27
force-pushed
the
repackage-everything-with-node2nix
branch
2 times, most recently
from
3616b10
to
2d55e02
Compare
|
nox-review exited with code 0 on my machine. |
both packages are available at the default NPM registry. related to NixOS#31032
Airfield suffered from loose version constraints which caused severe version (and API) conflicts between its dependencies and transitive ones. Furthermore the `npm2nix` packaging is deprecated and needed to be replaced by `node2nix`. see NixOS#31032
Ma27
force-pushed
the
repackage-everything-with-node2nix
branch
from
2d55e02
to
daf76db
Compare
|
btw I resolved the merge conflicts... |
|
Great work here! Bonus: this should close #24271 |
|
cc @svanderburg |
|
Great work! |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Please have a look at the commits to see a detailed description of the changes.
Further effort on #31032
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)