Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firefox: 56.0.2 -> 57.0 [Security fixes] #31661

Merged
merged 5 commits into from Nov 14, 2017
Merged

firefox: 56.0.2 -> 57.0 [Security fixes] #31661

merged 5 commits into from Nov 14, 2017

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Nov 14, 2017

Motivation for this change
  • Various security fixes
  • A completely new browsing engine, designed to take full advantage of the processing power in modern devices
  • A redesigned interface with a clean, modern appearance, consistent visual elements, and optimizations for touch screens
  • Legacy extensions will no longer work.

https://www.mozilla.org/en-US/firefox/57.0/releasenotes/
https://www.mozilla.org/en-US/security/known-vulnerabilities/firefox/#firefox57

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

firefox-esr is not tested.

@taku0 taku0 mentioned this pull request Nov 14, 2017
Merged
8 tasks
@fpletz
Copy link
Member

fpletz commented Nov 14, 2017

Does this version of firefox depend on the nspr and nss updates? This could complicate backports.

@taku0
Copy link
Contributor Author

taku0 commented Nov 14, 2017

@fpletz Yes, Firefox always depends on the latest NSPR and NSS. The configure script checks the version.

@tokudan
Copy link
Contributor

tokudan commented Nov 14, 2017

I've added a pull request to backport firefox-bin to release-17.09 in #31663

@7c6f434c 7c6f434c merged commit cacd720 into NixOS:master Nov 14, 2017
@lheckemann
Copy link
Member

This changes the options used to build the ESR as well, though I don't really think it should…

@domenkozar
Copy link
Member

I've backported the source version as well.

@fpletz
Copy link
Member

fpletz commented Nov 16, 2017

@domenkozar It won't compile, though: #31706

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@taku0 @fpletz @tokudan @lheckemann @domenkozar @7c6f434c @GrahamcOfBorg