kernel config: Enable MEDIA_CONTROLLER #31881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this disabled, cameras would not get a `/dev/mediaX` entry matching the `/dev/videoX` which broke any application (e.g: `uvcdynctrl -l`, `media-ctl -p`) depending on this interface.
NeQuissimus
approved these changes
Nov 21, 2017
|
@GrahamcOfBorg build linuxPackages_rpi.kernel |
|
@grahamc Why is it trying to build on darwin? oO |
|
The build fanout is too stupid to not :) |
|
FWIW, building |
There was a problem hiding this comment.
Failure for system: x86_64-linux
^~~~~
cc1: some warnings being treated as errors
make[4]: *** [/tmp/nix-build-linux-4.9.59-1.20171029.drv-0/source/scripts/Makefile.build:300: drivers/video/fbdev/rpisense-fb.o] Error 1
make[3]: *** [/tmp/nix-build-linux-4.9.59-1.20171029.drv-0/source/scripts/Makefile.build:544: drivers/video/fbdev] Error 2
make[2]: *** [/tmp/nix-build-linux-4.9.59-1.20171029.drv-0/source/scripts/Makefile.build:544: drivers/video] Error 2
make[1]: *** [/tmp/nix-build-linux-4.9.59-1.20171029.drv-0/source/Makefile:991: drivers] Error 2
make[1]: Leaving directory '/tmp/nix-build-linux-4.9.59-1.20171029.drv-0/build'
make: *** [Makefile:150: sub-make] Error 2
builder for ‘/nix/store/4xi8b21q16nbajc9x1jxd8278bp2ibn1-linux-4.9.59-1.20171029.drv’ failed with exit code 2
error: build of ‘/nix/store/4xi8b21q16nbajc9x1jxd8278bp2ibn1-linux-4.9.59-1.20171029.drv’ failed
|
Thanks @dezgeg. Is it possible to backport as well to 17.09? |
|
Sure. bcbd14e |
|
Nice, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this disabled, cameras would not get a
/dev/mediaXentry matchingthe
/dev/videoXwhich broke any application (e.g:uvcdynctrl -l,media-ctl -p) depending on this interface.Should also be applied to 17.09.
Motivation for this change
Broken utilities which work seamlessly on Ubuntu 16.04 but are unusable on Nixos (because of the missing config). Unable to properly setup a camera from "The Imaging Source".
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)Tested configure seamlessly with all supported kernels:
Tested complete build with
linuxPackages_4_9.kernel, booted with it and now successfully useduvcdynctrl -l,media-ctl -pand broken gstreamer pipelines with my camera./dev/media0now show up when I plug my usb camera.