pythonPackages.autoflake: init at 1.0 #31879
Conversation
| @@ -0,0 +1,20 @@ | |||
| { stdenv, buildPythonPackage, fetchPypi, pyflakes }: | |||
|
|
|||
| buildPythonPackage rec { | |||
There was a problem hiding this comment.
This does not look a library to me. If so, can you use buildPythonApplication and move it to all-packages.nix?
pkgs/top-level/python-packages.nix
Outdated
| @@ -661,6 +661,8 @@ in { | |||
| }; | |||
| }; | |||
|
|
|||
| autoflake = callPackage ../development/python-modules/autoflake { }; | |||
|
|
|||
| autopep8 = callPackage ../development/python-modules/autopep8 { }; | |||
There was a problem hiding this comment.
autopep8 might be also a candidate... but this does not need to be done in this pr.
yuriaisaka
force-pushed
the
pr-py-autoflake-init
branch
from
3bd0c96 to
afaffc1
Compare
|
@Mic92 Thank you very much for the suggestions, I agree that this (and perhaps also Anyways, I've updated the pr and made it a Python3 app. |
pkgs/top-level/all-packages.nix
Outdated
| @@ -511,6 +511,8 @@ with pkgs; | |||
| python3Packages = python34Packages; | |||
| }; | |||
|
|
|||
| autoflake = callPackage ../development/python-modules/autoflake { }; | |||
There was a problem hiding this comment.
maybe:
pkgs/development/tools/analysis/
as a directory?
There was a problem hiding this comment.
Yep, I'll do that, thanks!
Or, maybe can I dig pkgs/development/tools/python/ and use the directory?
Langs like guile, haskell, ocaml, java, .. seem to be doing that.
go is a notable exception and spreads goimports, gotags etc right under developement/tools.
yuriaisaka
force-pushed
the
pr-py-autoflake-init
branch
from
afaffc1 to
26715fe
Compare
|
Thanks! |
Motivation for this change
autoflake( https://pypi.python.org/pypi/autoflake ) is a tool that automatically removes unused imports and unused variables from Python code.Primarily, it is a standalone tool, but we put it under
python-modulesfollowing the way how the similar packagepythonPackages.autopep8is packaged.Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)