Speed up local action execution #3017
Conversation
| future<Result> f = make_ready_future( | ||
| get_remote_result_type::call(std::move(result))); | ||
|
|
||
| return keep_alive(std::move(f), id); |
There was a problem hiding this comment.
I don't think we need to keep the id alive here. The future is already done and the handler will be called immediately having no effect at all.
There was a problem hiding this comment.
I added this to maintain semantic compatibility with the old code. A user may rely on the id being kept alive until the value was extracted from the future.
There was a problem hiding this comment.
Hmm, in which scenario would that be the case? Originally, the keep alive was there to ensure that the component stays alive until the result is delivered. In the case where have a local synchronous invocation, this holds true. In addition, the handler is called immediately with the id_type refcounter being decremented.
| action_type::execute_function( | ||
| addr.address_, addr.type_, std::forward<Ts>(vs)...); | ||
|
|
||
| return keep_alive(make_ready_future(), id); |
There was a problem hiding this comment.
Same here regarding keep_alive
| addr.address_, addr.type_, std::forward<Ts>(vs)...); | ||
|
|
||
| return keep_alive(std::move(f), id); | ||
| } |
hkaiser
force-pushed
the
action_performance
branch
from
0ce15e2
to
fac4e4b
Compare
|
@sithhell Your comment shave been addressed. |
- this patch significantly speeds up local action execution (both, direct and non-direct) by avoiding to construct a (remote) promise but instead directly scheduling the function bound to the action as a local thread, while using a simple (local-only) future.
hkaiser
force-pushed
the
action_performance
branch
from
fac4e4b
to
4377a55
Compare
direct and non-direct) by avoiding to construct a (remote) promise
but instead directly scheduling the function bound to the action
as a local thread, while using a simple (local-only) future.
the function