ac - init at 0.1.1 #31342
Closed
ac - init at 0.1.1 #31342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Nov 7, 2017
| src = fetchFromGitHub { | ||
| owner = "vmchale"; | ||
| repo = "fastcat"; | ||
| rev = "5031c47631ea5a31d4eb8a584c8226a698453125"; |
There was a problem hiding this comment.
Can you also tag this release on github, so we can use the version tag here instead of the commit.
Mic92
reviewed
Nov 7, 2017
| meta = with stdenv.lib; { | ||
| homepage = https://github.com/vmchale/fastcat; | ||
| license = licenses.bsd3; | ||
| maintainers = []; |
There was a problem hiding this comment.
Do you want to maintain this package?
lukateras
reviewed
Nov 8, 2017
| @@ -370,6 +370,8 @@ with pkgs; | |||
|
|
|||
| acbuild = callPackage ../applications/misc/acbuild { }; | |||
|
|
|||
| ac = callPackage ../tools/system/ac { }; | |||
There was a problem hiding this comment.
Two- and three-letter names like ac at top-level should be reserved for old well-known Unix utilities. I think it's better to call it fastcat or ats-cat to avoid confusion. Also, it should be under ../tools/misc, like coreutils.
|
Feel free to open a new pull request if you're still interested in getting this into Nixpkgs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add
acas a package.Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)