vcftools: init at 0.1.15 #31339
Merged
vcftools: init at 0.1.15 #31339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dezgeg
reviewed
Nov 7, 2017
| sha256 = "15yxr4kidqb42gkbd6rjra6b07wpl6rgivlh9q73yavh5myafqk4"; | ||
| }; | ||
|
|
||
| buildInputs = [ stdenv autoreconfHook gcc pkgconfig zlib perl ]; |
There was a problem hiding this comment.
Mentioning stdenv or gcc here should be unnecessary.
|
Besides the one comment, looks good. |
dezgeg
reviewed
Nov 7, 2017
| description = "A set of tools written in Perl and C++ for working with VCF files, such as those generated by the 1000 Genomes Project"; | ||
| license = licenses.lgpl3; | ||
| homepage = https://vcftools.github.io/index.html; | ||
| maintainers = [ maintainers.rybern ]; |
There was a problem hiding this comment.
Add platforms = platforms.linux; here (or in case you tested on MacOS as well, platforms.unix).
|
@dezgeg Thanks, applied changes |
Mic92
reviewed
Nov 7, 2017
| sha256 = "15yxr4kidqb42gkbd6rjra6b07wpl6rgivlh9q73yavh5myafqk4"; | ||
| }; | ||
|
|
||
| buildInputs = [ autoreconfHook pkgconfig zlib perl ]; |
There was a problem hiding this comment.
- buildInputs = [ autoreconfHook pkgconfig zlib perl ];
+ buildInputs = [ zlib perl ];
+ nativeBuildInputs = [ autoreconfHook pkgconfig ];There was a problem hiding this comment.
Cool - I found the GitHub issue describing the difference, but I'm not clear on how I would know which input goes where
There was a problem hiding this comment.
Everything that is used to build the project but does not end up being linked against. In doubt reviewer can also fix that.
|
@dezgeg ready to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)