CODEOWNERS: fix path notation #31101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zimbatm
force-pushed
the
codeowners-syntax-fix
branch
from
df8a345
to
4c9b01a
Compare
|
@zimbatm if you could, there’s also an error in Darwin maintainers. It should be Also are trailing slashes relevant at all in CODEOWNERS? I suspect not but might impact traversal somehow. |
orivej
approved these changes
Nov 1, 2017
This format uses the path matching algorithm as the .gitignore format. The paths need to be prefixed with a / to become absolute, otherwise it will match all of these files. The paths will also match any of the sub-paths by default so it's not necessary to use the `*` like in bash globbing.
zimbatm
force-pushed
the
codeowners-syntax-fix
branch
from
4c9b01a
to
088ce9f
Compare
|
thanks @matthewbauer, fixed |
nbp
approved these changes
Nov 2, 2017
matthewbauer
approved these changes
Nov 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This format uses the path matching algorithm as the .gitignore format.
The paths need to be prefixed with a / to become absolute, otherwise it
will match all of these files.
The paths will also match any of the sub-paths by default so it's not
necessary to use the
*like in bash globbing.Motivation for this change
I noticed that @nbp was marked as a codeowner on one of my PRs because he's owning /default.nix. This is probably not what he wants.