Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] xandikos: init at 0.0.6 #31096

Closed
wants to merge 4 commits into from
Closed

[WIP] xandikos: init at 0.0.6 #31096

wants to merge 4 commits into from

Conversation

matthiasbeyer
Copy link
Contributor

@matthiasbeyer matthiasbeyer commented Nov 1, 2017 •
edited by grahamc

Motivation for this change

OwnCloud SUCKS so much for syncing calendar & contact data, fucks up my data every other day, does not allow creating collections from clients (using vdirsyncer) ... so I need an alternative.

Radicale is HELL when trying to set it up,...it just won't work as I request.

So this is another caldav/carddav server which claims to be compatible with my android sync client and vdirsyncer... hopefully it is.

Still waiting to get this issue: jelmer/xandikos#70 resolved, though

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

WIP!

@matthiasbeyer
Copy link
Contributor Author

So it looks like dulwich gets build with fastimport, which is not python3 in nixpkgs, but xandikos needs/is python3.

Can someone tell me what to do?

@lukateras
Copy link
Member

lukateras commented Nov 1, 2017 •
edited

Yeah, this derivation builds Xandikos with Python 2:

$ head -1 result/bin/.xandikos-wrapped 
#!/nix/store/5xl4sc0fv2gcj0cbnvxja14yl89nk5c6-python-2.7.14/bin/python2.7

Not sure what to do just yet. fastimport seems to be a test dependency of dulwich, so ideally it should not be pulled in...

@matthiasbeyer
Copy link
Contributor Author

Issue solved. This works now, but I would like to add a service definition for this before it gets merged!

@matthiasbeyer
Copy link
Contributor Author

Added a service definition, though I don't know how to test this properly or even implement VM tests for it.

Can someone jump in? 😄

FRidh
FRidh requested changes Nov 1, 2017
View reviewed changes
nixos/modules/services/networking/xandikos.nix Outdated
type = types.bool;
default = true;
description = ''
AUtomatically create necessary directories.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Au

nixos/modules/services/networking/xandikos.nix Outdated
type = types.int;
default = 8080;
description = ''
Port to listen on
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dot

nixos/modules/services/networking/xandikos.nix Outdated
default = "/";
description = ''
Path to Xandikos.
(useful when Xandikos is behind a reverse proxy)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for parentheses.

@matthiasbeyer
Copy link
Contributor Author

Done. Still no tests, though.

@matthiasbeyer
Copy link
Contributor Author

Can someone suggest how to test this?

@matthiasbeyer
xandikos: 0.0.11 -> 0.1.0
ca8b2b1 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@infinisil
Copy link
Member

https://github.com/pimutils/vdirsyncer seems like an easy way to test this.

@ivan
Copy link
Member

ivan commented Sep 6, 2019

For the author, reviewers, and committers: this PR was scanned and appears to add a use of the deprecated types.string, which emits a warning as of #66346. Before merging, please change this to another type, possibly:

  • types.str for a single string where merging does not make sense, or cannot work
  • types.lines for multi-line configuration or scripts where merging is possible
  • types.listOf types.str for a mergeable list of strings

0x4A6F
0x4A6F reviewed Nov 7, 2019
View reviewed changes
nixos/modules/misc/ids.nix
@@ -340,6 +340,7 @@
cockroachdb = 313;
zoneminder = 314;
paperless = 315;
xandikos = 316;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we utilize systemd's DynamicUser here?

@matthiasbeyer matthiasbeyer deleted the add-xandikos branch November 9, 2019 16:40
@0x4A6F 0x4A6F mentioned this pull request Dec 11, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x4A6F 0x4A6F 0x4A6F left review comments

@FRidh FRidh FRidh requested changes

@nbp nbp Awaiting requested review from nbp

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
2.status: work-in-progress 6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@matthiasbeyer @lukateras @infinisil @ivan @FRidh @0x4A6F @matthewbauer @samueldr @GrahamcOfBorg