Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rambox: 0.5.12 -> 0.5.13 #31095

Merged
merged 2 commits into from Nov 2, 2017
Merged

rambox: 0.5.12 -> 0.5.13 #31095

merged 2 commits into from Nov 2, 2017

Conversation

ghost
Copy link

@ghost ghost commented Nov 1, 2017

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@ghost ghost requested a review from nbp as a code owner November 1, 2017 15:05
@ghost
Copy link
Author

ghost commented Nov 2, 2017

TODO wrapper instead of propagatedUserEnvPkgs

@ghost ghost closed this Nov 2, 2017
@ghost ghost reopened this Nov 2, 2017
@ghost
Copy link
Author

ghost commented Nov 2, 2017

Done

@Mic92
Copy link
Member

Mic92 commented Nov 2, 2017

Thanks!

@Mic92 Mic92 merged commit 6e90af6 into NixOS:master Nov 2, 2017
@ghost ghost deleted the rambox branch November 2, 2017 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbp nbp Awaiting requested review from nbp

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @GrahamcOfBorg