Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firefoxPackages: tor-browser: fix build #31105

Merged
merged 1 commit into from Nov 1, 2017
Merged

Conversation

orivej
Copy link
Contributor

@orivej orivej commented Nov 1, 2017

Motivation for this change
  1. rev contained a branch rather than a tag.
  2. Nix source paths have changed (Revert "fetchzip and friends: Set "name" to "source" by default" #31004 (comment)).
  3. It depends on gcc 5, which is going to be updated in gcc: 5.4.0 -> 5.5.0 #31088.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants