Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pomegranate: 0.8.0 -> 0.8.1 #31103

Merged
merged 3 commits into from Nov 2, 2017
Merged

pythonPackages.pomegranate: 0.8.0 -> 0.8.1 #31103

merged 3 commits into from Nov 2, 2017

Conversation

rybern
Copy link
Contributor

@rybern rybern commented Nov 1, 2017

Also now using GitHub instead of PiPy, because the PiPy version fails to build. Not sure why they aren't identical.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@rybern
pythonPackages.pomegranate: 0.8.0 -> 0.8.1
f5b773b 
Also now using GitHub instead of PiPy, because the PiPy version fails to build. Not sure why they aren't identical.
@rybern rybern requested a review from nbp as a code owner November 1, 2017 18:40
@disassembler
Copy link
Member

Missing pytest. Lots of errors like this:

conftest (unittest.loader._FailedTest) ... ERROR
test (unittest.loader._FailedTest) ... ERROR
testing (unittest.loader._FailedTest) ... ERROR
joblib.test (unittest.loader._FailedTest) ... ERROR
joblib.testing (unittest.loader._FailedTest) ... ERROR

======================================================================
ERROR: conftest (unittest.loader._FailedTest)
----------------------------------------------------------------------
ImportError: Failed to import test module: conftest
Traceback (most recent call last):
  File "/nix/store/d0im7d8gvk39xyhwnsqs57rmzvwy8g89-python3-3.6.3/lib/python3.6/unittest/loader.py", line 153, in loadTestsFromName
    module = __import__(module_name)
  File "/build/joblib-0.11/doc/conftest.py", line 2, in <module>
    from joblib.test.common import np, setup_autokill, teardown_autokill
  File "/build/joblib-0.11/joblib/test/__init__.py", line 1, in <module>
    from joblib.test import test_memory
  File "/build/joblib-0.11/joblib/test/test_memory.py", line 32, in <module>
    from joblib.test.common import with_numpy, np
  File "/build/joblib-0.11/joblib/test/common.py", line 12, in <module>
    from joblib.testing import SkipTest, skipif
  File "/build/joblib-0.11/joblib/testing.py", line 12, in <module>
    import pytest
ModuleNotFoundError: No module named 'pytest'

@rybern
Copy link
Contributor Author

rybern commented Nov 2, 2017 •
edited

@disassembler Good catch, I wasn't testing Python 3. But that appears to be a problem with python3Packages.joblib. In the mean time I could restrict this package to 2.7.. what's the right way to do that?

@rybern rybern requested a review from FRidh as a code owner November 2, 2017 08:21
@Mic92
Copy link
Member

Mic92 commented Nov 2, 2017

Now it works with both properly (python2/python3).

@Mic92 Mic92 merged commit 7daa035 into NixOS:master Nov 2, 2017
@rybern
Copy link
Contributor Author

rybern commented Nov 2, 2017

Nice!

@rybern rybern deleted the bump-pomegranate branch November 2, 2017 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbp nbp Awaiting requested review from nbp

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rybern @disassembler @Mic92 @GrahamcOfBorg