Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/network-interfaces: Add " around network interface names #31476

Merged
merged 1 commit into from Nov 10, 2017
Merged

nixos/network-interfaces: Add " around network interface names #31476

merged 1 commit into from Nov 10, 2017

Conversation

florianjacob
Copy link
Contributor

in assertion messages to avoid misinterpretations when the interface name contains a dot, making the output consistent with the new assertion against too-long interface names.

Motivation for this change

Was brought up by @4z3 at #30127 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@florianjacob
nixos/network-interfaces: Add " around network interface names
fe3751d 
in assertion messages to avoid misinterpretations when the interface name contains a dot.
@florianjacob florianjacob mentioned this pull request Nov 10, 2017
Merged
8 tasks
@Mic92 Mic92 merged commit b72e2ec into NixOS:master Nov 10, 2017
@florianjacob florianjacob deleted the network-interfaces-assertion-messages branch November 10, 2017 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@florianjacob @Mic92 @GrahamcOfBorg