dotty: init at 0.4.0-RC1 #31478

karolchmist · 2017-11-10T11:10:51Z

Motivation for this change

Dotty is a platform to try out new language concepts and compiler technologies for Scala. The focus is mainly on simplification. The theory behind these constructs is researched in DOT, a calculus for dependent object types.

http://dotty.epfl.ch/

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

lukateras

Builds and seems to work, REPL loads up! However, meta.maintainers should be probably set.

In regards to bin/common, I don't have a strong stance on this one, but it might be better to wrap this derivation so that it's not leaked, as it's done in Rambox and Retroarch.

lukateras · 2017-11-10T13:37:53Z

pkgs/development/compilers/scala/dotty.nix

+    '';
+    homepage = http://dotty.epfl.ch/;
+    license = stdenv.lib.licenses.bsd3;
+    platforms = stdenv.lib.platforms.all;


If you are going to maintain it, add yourself to lib/maintainers.nix and to meta.maintainers of this derivation.

lukateras · 2017-11-10T13:44:33Z

pkgs/development/compilers/scala/dotty.nix

+      file=$(basename $p)
+
+      # no need to wrap common
+      if [[ "$file" = "common" ]] ; then


This leaks bin/common into shared bin, which might be a rather common script name!

Fixed by moving to a new shared folder.

lukateras · 2017-11-10T13:53:43Z

pkgs/development/compilers/scala/dotty.nix

+    mkdir -p $out
+    mv * $out
+
+    for p in $out/bin/* ; do


Nitpick: this fits better in fixupPhase, and you could write this as find expression:

fixupPhase = '' for p in $(find $out/bin -mindepth 1 -not -name common); do wrapProgram $p --set JAVA_HOME ${jre} done '';

Better yet, you can only patch $out/bin/common, as it's the only script that uses JAVA_HOME:

fixupPhase = '' wrapProgram $out/bin/common --set JAVA_HOME ${jre} '';

I reorganised a bit the phases, should be cleaner now.

I can't make it work when wrapping common only...

lukateras · 2017-11-10T13:56:10Z

pkgs/development/compilers/scala/dotty.nix

+    done    
+  '';
+
+  meta = {


Just a note: you can skip stdenv.lib inside meta if you add with stdenv.lib; to the attribute set:

meta = with stdenv.lib; { license = licenses.bsd3; platforms = platforms.all; };

lukateras · 2017-11-10T13:58:46Z

pkgs/top-level/all-packages.nix

@@ -6253,6 +6253,7 @@ with pkgs;
  scala_2_10 = callPackage ../development/compilers/scala/2.10.nix { };
  scala_2_11 = callPackage ../development/compilers/scala/2.11.nix { };
  scala_2_12 = callPackage ../development/compilers/scala { jre = jre8; };
+  scala_dotty = callPackage ../development/compilers/scala/dotty.nix { jre = jre8;};


It's easier to find packages if derivation name and attribute name match. Maybe just dotty?

The idea was to put it next to "standard" scala... But simply dotty is fine as well.

I guess that it will disappear anyway with scala 3.0 coming out one day. Isn't it a problem to create such an ephemeral package? On the other hand, anyone using it should be aware of it...

karolchmist · 2017-11-10T15:52:51Z

Thanks @yegortimoshenko for the feedback, this is my first new package so any help is appreciated. I'll come back with the fixes.

disassembler · 2017-11-15T15:27:04Z

pkgs/development/compilers/scala/dotty.nix

+  version = "0.4.0-RC1";
+  name = "dotty-${version}";
+
+  src = fetchurl {


Can you use fetchFromGitHub here instead?

@disassembler This is a prebuilt release, to make this derivation build completely from source would require a lot of non-trivial work.

disassembler

Also, please squash and review CONTRIBUTING.md for commit message style.

disassembler · 2017-11-15T15:29:48Z

@GrahamcOfBorg build dotty

GrahamcOfBorg

Failure for system: x86_64-darwin

these derivations will be built:
  /nix/store/5anb357x98zmlhbsji32ivl49kyywyd5-dotty-0.4.0-RC1.tar.gz.drv
  /nix/store/irc646li1l7mpb5gy9xs4q1nwr96dzg9-dotty-0.4.0-RC1.drv
unable to connect to ‘mac1’
unable to open SSH connection to ‘mac1’, trying other available machines...
building path(s) ‘/nix/store/4gqrvc8920jsd8f9l7lzprqaigxvh4v1-dotty-0.4.0-RC1.tar.gz’
error: a ‘x86_64-darwin’ is required to build ‘/nix/store/5anb357x98zmlhbsji32ivl49kyywyd5-dotty-0.4.0-RC1.tar.gz.drv’, but I am a ‘x86_64-linux’

GrahamcOfBorg

Success for system: x86_64-linux

setting SOURCE_DATE_EPOCH to timestamp 1508169341 of file dotty-0.4.0-RC1/lib/dotty-library_0.4-0.4.0-RC1.jar
patching sources
configuring
no configure script, doing nothing
building
build flags: SHELL=/nix/store/4ada72n7785wwazv42fhsnxjvilaa3aj-bash-4.4-p12/bin/bash
Run make install
installing
post-installation fixup
/nix/store/vxzl4i68vgrfmdhrfcj61cs8b4iazfiq-dotty-0.4.0-RC1

lukateras · 2017-11-15T15:57:21Z

@disassembler Maybe this could be just squash and merged when ready? It will automatically pick up the pull request name as commit message, and the pull request name follows CONTRIBUTING.md. It's also possible to change the commit message, if necessary.

disassembler · 2017-11-15T16:14:21Z

based on @yegortimoshenko comments on this being a binary release and not source code, I merged and squashed. Thanks for the contribution!

karolchmist changed the title ~~doty: init at 0.0.4-RC1~~ dotty: init at 0.0.4-RC1 Nov 10, 2017

karolchmist changed the title ~~dotty: init at 0.0.4-RC1~~ dotty: init at 0.4.0-RC1 Nov 10, 2017

GrahamcOfBorg added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Nov 10, 2017

lukateras requested changes Nov 10, 2017

View reviewed changes

c0bw3b added the 8.has: package (new) label Nov 11, 2017

karolchmist added 2 commits November 13, 2017 13:47

Add Scala dotty, at version 0.4.0-RC1

da94de1

[CodeReview] Added suggestions by yegortimoshenko

e8c8163

karolchmist force-pushed the dotty branch from dc83377 to e8c8163 Compare November 13, 2017 13:10

karolchmist requested review from edolstra and nbp as code owners November 13, 2017 13:10

disassembler suggested changes Nov 15, 2017

View reviewed changes

GrahamcOfBorg reviewed Nov 15, 2017

View reviewed changes

GrahamcOfBorg approved these changes Nov 15, 2017

View reviewed changes

disassembler merged commit 07bd44b into NixOS:master Nov 15, 2017

karolchmist mentioned this pull request Nov 20, 2017

Dotty in conflict with Scala #31858

Closed

karolchmist deleted the dotty branch January 6, 2018 18:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

dotty: init at 0.4.0-RC1 #31478

dotty: init at 0.4.0-RC1 #31478

karolchmist commented Nov 10, 2017 •

edited

lukateras left a comment •

edited

lukateras Nov 10, 2017

karolchmist Nov 13, 2017

lukateras Nov 10, 2017

karolchmist Nov 13, 2017

lukateras Nov 10, 2017 •

edited

karolchmist Nov 13, 2017

lukateras Nov 10, 2017

karolchmist Nov 13, 2017

lukateras Nov 10, 2017

karolchmist Nov 13, 2017

karolchmist commented Nov 10, 2017

disassembler Nov 15, 2017

lukateras Nov 15, 2017

disassembler left a comment •

edited

disassembler commented Nov 15, 2017

GrahamcOfBorg left a comment

GrahamcOfBorg left a comment

lukateras commented Nov 15, 2017 •

edited

disassembler commented Nov 15, 2017

dotty: init at 0.4.0-RC1 #31478

dotty: init at 0.4.0-RC1 #31478

Conversation

karolchmist commented Nov 10, 2017 • edited

Motivation for this change

Things done

lukateras left a comment • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lukateras Nov 10, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

karolchmist commented Nov 10, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

disassembler left a comment • edited

Choose a reason for hiding this comment

disassembler commented Nov 15, 2017

GrahamcOfBorg left a comment

Choose a reason for hiding this comment

GrahamcOfBorg left a comment

Choose a reason for hiding this comment

lukateras commented Nov 15, 2017 • edited

disassembler commented Nov 15, 2017

karolchmist commented Nov 10, 2017 •

edited

lukateras left a comment •

edited

lukateras Nov 10, 2017 •

edited

disassembler left a comment •

edited

lukateras commented Nov 15, 2017 •

edited