electrum: 2.9.3 -> 3.0.2 #31470

Moredread · 2017-11-10T06:57:59Z

Motivation for this change

Upgrading electrum to the latest version. As it doesn't support Python 2 anymore, it is now built against Python 3. For this, jsonrpclib-pelix is needed, a fork of jsonrpclib, that works with Python 3. See the first of the commit in the PR. If this is acceptable, would you, @joachifm, also be the maintainer of the new package?

I couldn't test it built against master, as I get an error message when I run the binary. I think it's an incompatibility of the QT5 runtime library. See the comment below for details. I backported it to 17.09 (only needs a later version of protobuf, e.g. protobuf3_2), and there it works fine.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

Moredread · 2017-11-10T07:01:16Z

I couldn't test it built against master, as I get an error message when I run the binary on a 17.09 system:

> QT_DEBUG_PLUGINS=1 ./result/bin/electrum

(... skipped ...)

Got keys from plugin meta data ("xcb")
QFactoryLoader::QFactoryLoader() checking directory path "/nix/var/nix/profiles/default/lib/qt-5.9/plugins/platforms" ...
QFactoryLoader::QFactoryLoader() checking directory path "/run/current-system/sw/lib/qt-5.9/plugins/platforms" ...
QFactoryLoader::QFactoryLoader() looking at "/run/current-system/sw/lib/qt-5.9/plugins/platforms/libqminimal.so"
Got keys from plugin meta data ("minimal")
QFactoryLoader::QFactoryLoader() looking at "/run/current-system/sw/lib/qt-5.9/plugins/platforms/libqoffscreen.so"
Got keys from plugin meta data ("offscreen")
QFactoryLoader::QFactoryLoader() looking at "/run/current-system/sw/lib/qt-5.9/plugins/platforms/libqvnc.so"
Got keys from plugin meta data ("vnc")
QFactoryLoader::QFactoryLoader() looking at "/run/current-system/sw/lib/qt-5.9/plugins/platforms/libqxcb.so"
Got keys from plugin meta data ("xcb")
QFactoryLoader::QFactoryLoader() checking directory path "/nix/store/166s7l3yjqfc8dj5hfqjb09dbfvp1850-python3-3.6.3/bin/platforms" ...
Cannot load library /nix/store/i1mgik5x2f8akjwhjcd0r62259s89592-qtbase-5.9.1-bin/lib/qt-5.9/plugins/platforms/libqxcb.so: (/nix/store/h1a1ncbkkhapzm0509plqjlfrgxw22f3-glibc-2.25-49/lib/libresolv.so.2: symbol __res_maybe_init, version GLIBC_PRIVATE not defined in file libc.so.6 with link time reference)
QLibraryPrivate::loadPlugin failed on "/nix/store/i1mgik5x2f8akjwhjcd0r62259s89592-qtbase-5.9.1-bin/lib/qt-5.9/plugins/platforms/libqxcb.so" : "Cannot load library /nix/store/i1mgik5x2f8akjwhjcd0r62259s89592-qtbase-5.9.1-bin/lib/qt-5.9/plugins/platforms/libqxcb.so: (/nix/store/h1a1ncbkkhapzm0509plqjlfrgxw22f3-glibc-2.25-49/lib/libresolv.so.2: symbol __res_maybe_init, version GLIBC_PRIVATE not defined in file libc.so.6 with link time reference)"
This application failed to start because it could not find or load the Qt platform plugin "xcb"
in "".

Available platform plugins are: minimal, offscreen, vnc, xcb.

Reinstalling the application may fix this problem.
[1]    22886 abort      QT_DEBUG_PLUGINS=1 ./result/bin/electrum

FRidh · 2017-11-11T15:48:28Z

pkgs/applications/misc/electrum/default.nix

    # Recording the creation timestamps introduces indeterminism to the build
    sed -i '/Created: .*/d' gui/qt/icons_rc.py
  '';

  postInstall = ''
    # Despite setting usr_share above, these files are installed under
    # $out/nix ...
-    mv $out/lib/python2.7/site-packages/nix/store"/"*/share $out
-    rm -rf $out/lib/python2.7/site-packages/nix
+    mv $out/lib/python3.6/site-packages/nix/store"/"*/share $out


${python.sitePackages}

I've changed it

FRidh · 2017-11-11T15:49:15Z

pkgs/development/python-modules/jsonrpclib-pelix/default.nix

+    description = "JSON RPC client library - Pelix compatible fork";
+    homepage = https://pypi.python.org/pypi/jsonrpclib-pelix/;
+    license = lib.licenses.asl20;
+    maintainers = [ lib.maintainers.joachifm ];


Is @joachifm maintaining this expression?

They haven't replied yet. What's the procedure for finding a maintainer for necessary new dependencies?

You can make yourself the maintainer or leave it empty (preference on the former).

I've removed the maintainer line for now, I'm not sure I can provide the level of attention needed atm.

I only care to the extent that it affects electrum, so wouldn't be maintaining it per se. It used to be internal to the electrum expression for that reason.

I've added myself as maintainer afterall.

This fork of jsonrpclib supports Python 3 and is necessary for electrum from version 3.0.0 onwards. Adding myself - moredread - as maintainer.

Moredread · 2017-11-18T17:53:23Z

Have added myself as maintainer, and updated the package to 3.0.2, which was released in the meantime.

nonsequitur · 2017-11-19T23:35:02Z

For those who want to run Electrum 3.0.2 now, here's a quick derivation with pinned dependencies:
https://gist.github.com/nonsequitur/1782996516bdf39b16e647842b1ae4cf
(The patch proposed in this PR still doesn't run on master: xcb not found)

Edit: Explicitly reference this PR.

Moredread · 2017-11-20T10:01:14Z

@nonsequitur do you mean my PR or your gist that isn't working with master? Are you running NixOS 17.09 or master on your system?

nonsequitur · 2017-11-20T10:16:12Z

@Moredread I'm running NixOS revision eafd703 which is in the 17.09 channel.
The electrum build from my gist is working on that system.
When changing the nixpkgs version in the gist to master, I'm getting the xdg error.
I haven't tried running your PR (or the master gist) with NixOS master installed, because that shouldn't make a difference. The dependencies in my gist are completely fixed.
(I've clarified my original post.)

joachifm · 2017-12-01T20:48:07Z

Any way to move this ahead?

Moredread · 2017-12-02T00:27:32Z

Someone needs to find out why the xcb plugin loading doesn't work when build against master. I've tested it with a system running master, and the xcb error happens there too. :/

joachifm · 2017-12-03T17:38:53Z

Similar libc errors reported in #32273 and #32065

joachifm · 2017-12-12T13:34:12Z

Basically, the problem is a runtime impurity, which can be "fixed" on non-NixOS by setting QT_PLUGIN_PATH and LD_LIBRARY_PATH appropriately. I've merged this in the interim. Thank you

joachifm · 2017-12-12T13:35:53Z

(The above worked for me, anyways)

Moredread · 2017-12-13T21:46:20Z

@joachifm Thanks :)

I think it might be a good idea to backport it to the 17.09 channel, as pre-3.0 has problems with SegWit addresses? As the issue with QT/xcb didn't happen on the older channel, that shouldn't be a blocker.

joachifm · 2017-12-13T23:01:14Z

If there are problems with the version on stable, a bump makes sense to me.

joachifm · 2017-12-13T23:22:26Z

Hm, OTOH I see that SegWit support was added in 3.0, so under a strict interpretation that'd count as a new feature not a bug fix, or is there a specific issue with the 2.9 series? (I'm not really clued into SegWit or electrum's support for it).

Moredread · 2017-12-17T18:07:58Z

@joachifm I had crashes with watching wallets, that had SegWit transactions, but I have to check whether it was the latestst 2.X release

joachifm · 2017-12-17T18:17:03Z

@Moredread I see. If you can ascertain whether there are issues with 2.9, please open a cherry-pick PR if you have the time, or let me know and I'll pick it when I can.

joachifm · 2018-01-07T12:48:33Z

Meanwhile, electrum 3.x has been backported to fix a security issue.

Moredread requested a review from FRidh as a code owner November 10, 2017 06:57

Moredread force-pushed the electrum-3.0.1 branch from 4e1b3b2 to 12dd9b4 Compare November 10, 2017 07:06

GrahamcOfBorg added 10.rebuild-darwin: 0 10.rebuild-linux: 0 labels Nov 10, 2017

Moredread force-pushed the electrum-3.0.1 branch 2 times, most recently from 1d79090 to 7c2e0b6 Compare November 10, 2017 07:16

GrahamcOfBorg added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Nov 10, 2017

c0bw3b added the 8.has: package (update) label Nov 11, 2017

FRidh requested changes Nov 11, 2017

View reviewed changes

Moredread force-pushed the electrum-3.0.1 branch 2 times, most recently from cf4255c to 14e0589 Compare November 15, 2017 16:35

Moredread added 3 commits November 18, 2017 18:46

maintainers: Add moredread

88c9e7f

pythonPackages.jsonrpclib-pelix: init at 0.3.1

5ec4b2d

This fork of jsonrpclib supports Python 3 and is necessary for electrum from version 3.0.0 onwards. Adding myself - moredread - as maintainer.

electrum: 2.9.3 -> 3.0.2

1b85d87

Moredread force-pushed the electrum-3.0.1 branch from 14e0589 to 1b85d87 Compare November 18, 2017 17:47

Moredread changed the title ~~electrum: 2.9.3 -> 3.0.1~~ electrum: 2.9.3 -> 3.0.12 Nov 18, 2017

Moredread changed the title ~~electrum: 2.9.3 -> 3.0.12~~ electrum: 2.9.3 -> 3.0.2 Nov 18, 2017

joachifm closed this Dec 12, 2017

Moredread deleted the electrum-3.0.1 branch December 13, 2017 21:43

joachifm mentioned this pull request Dec 28, 2017

electrum: Add QT_QPA_PLATFORM_PLUGIN_PATH #33146

Closed

8 tasks

Moredread mentioned this pull request Mar 29, 2018

electrum fails to start with "This application failed to start because it could not find or load the Qt platform plugin "xcb" in ""." #38053

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

electrum: 2.9.3 -> 3.0.2 #31470

electrum: 2.9.3 -> 3.0.2 #31470

Moredread commented Nov 10, 2017 •

edited

Moredread commented Nov 10, 2017

FRidh Nov 11, 2017

Moredread Nov 15, 2017

FRidh Nov 11, 2017

Moredread Nov 15, 2017

disassembler Nov 15, 2017

Moredread Nov 15, 2017

joachifm Nov 15, 2017

Moredread Nov 18, 2017

Moredread commented Nov 18, 2017

nonsequitur commented Nov 19, 2017 •

edited

Moredread commented Nov 20, 2017

nonsequitur commented Nov 20, 2017 •

edited

joachifm commented Dec 1, 2017

Moredread commented Dec 2, 2017 •

edited

joachifm commented Dec 3, 2017

joachifm commented Dec 12, 2017

joachifm commented Dec 12, 2017

Moredread commented Dec 13, 2017

joachifm commented Dec 13, 2017

joachifm commented Dec 13, 2017

Moredread commented Dec 17, 2017

joachifm commented Dec 17, 2017

joachifm commented Jan 7, 2018

electrum: 2.9.3 -> 3.0.2 #31470

electrum: 2.9.3 -> 3.0.2 #31470

Conversation

Moredread commented Nov 10, 2017 • edited

Motivation for this change

Things done

Moredread commented Nov 10, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Moredread commented Nov 18, 2017

nonsequitur commented Nov 19, 2017 • edited

Moredread commented Nov 20, 2017

nonsequitur commented Nov 20, 2017 • edited

joachifm commented Dec 1, 2017

Moredread commented Dec 2, 2017 • edited

joachifm commented Dec 3, 2017

joachifm commented Dec 12, 2017

joachifm commented Dec 12, 2017

Moredread commented Dec 13, 2017

joachifm commented Dec 13, 2017

joachifm commented Dec 13, 2017

Moredread commented Dec 17, 2017

joachifm commented Dec 17, 2017

joachifm commented Jan 7, 2018

Moredread commented Nov 10, 2017 •

edited

nonsequitur commented Nov 19, 2017 •

edited

nonsequitur commented Nov 20, 2017 •

edited

Moredread commented Dec 2, 2017 •

edited