Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skypeforlinux: 5.5.0.1 -> 8.11.0.4 #31466

Conversation

jraygauthier
Copy link
Member

Motivation for this change

Previous beta version what put out of service by Microsoft.
Now use latest and it works fine (both video and sound).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@orivej
Copy link
Contributor

orivej commented Nov 10, 2017

Please, no unstable releases such as 8.10.76.7, no 8.9.0.1, and do not remove 5.5.0.1 until it disappears upstream. Previous discussion at #31129. 8.10.0.4 under the attribute skypeforlinux_8 would be OK.

@orivej orivej closed this Nov 10, 2017
@orivej orivej reopened this Nov 27, 2017
@orivej orivej changed the title skypeforlinux: 5.5.0.1 -> 8.10.76.7 skypeforlinux: 5.5.0.1 -> 8.11.0.4 Nov 27, 2017
@orivej
Copy link
Contributor

orivej commented Nov 27, 2017

I'd like to reuse this PR as the basis for an update since 5.5.0.1 no longer connects with the service with the message "Sorry, this version of Skype is not supported anymore".

@orivej orivej force-pushed the jrg/skypeforlinux_was_broken_update_to_latest branch from f573acf to f7ac076 Compare November 27, 2017 16:29
@orivej orivej merged commit 6158563 into NixOS:master Nov 27, 2017
@orivej
Copy link
Contributor

orivej commented Nov 27, 2017

@jraygauthier Thank you!

@jraygauthier
Copy link
Member Author

Nice, thank you for the merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants