-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ASK] Ethernet Frame struct #77
Comments
The frame check sequence, just like the preamble and start delimiter, are handled by hardware. |
Note the difference between ethernet packet and ethernet frame; the packet includes preamble and FCS, whereas the frame does not. |
thx, the wikipedia lie to me -_- |
now the wikipedia page Ethernet_frame have been fixed 😄 thank you let me know that. |
Looks like the Wikipedia people disagree: https://en.wikipedia.org/w/index.php?title=Ethernet_frame&diff=809483347&oldid=809464039 |
okay |
The crc checksum from the ethernet frame is ignored by the smoltcp EthernetFrame struct (See: smoltcp-rs/smoltcp#77). This new function checks if the crc frame is left on the end of the ipv4 frame and reduces the slice size accordingly. This fixes any out of bounds errors from when the ipv4 length is assumed based on the length of the slice rather than the header value.
The crc checksum from the ethernet frame is ignored by the smoltcp EthernetFrame struct (See: smoltcp-rs/smoltcp#77). This new function checks if the crc frame is left on the end of the ipv4 frame and reduces the slice size accordingly. This fixes any out of bounds errors when handline fragmentation from when the ipv4 length is assumed based on the length of the slice rather than the header value.
Fixes Github issue smoltcp-rs#77
Code Lines: https://github.com/m-labs/smoltcp/blob/master/src/wire/ethernet.rs#L88-L91
The wiki page: https://en.wikipedia.org/wiki/Ethernet_frame#Structure
as you can see, wikipedia said ethernet frame after
payload
filed, have oneFrame check sequence (32‑bit CRC)
field , but i have not see in weethernet frame struct
.The text was updated successfully, but these errors were encountered: