Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

electron-cash: 2.9.3 -> 2.9.4 #31474

Closed
wants to merge 1 commit into from
Closed

Conversation

rycee
Copy link
Member

@rycee rycee commented Nov 10, 2017

Motivation for this change

To bump electron-cash version. I've also switched the package to downloading the tarball from the official source URL to allow verification using the upstream digital signature. Should be backported to stable because this version is needed for the Bitcoin Cash hard fork on the 13th Nov.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

CC @Lassulus

Also switch to downloading tarball from official source URL to allows
verification of digital signature.
@rycee
Copy link
Member Author

rycee commented Nov 10, 2017

Thanks! I've rebased this to master in ba7c23e and cherry-picked to 17.09 in e1b172d.

@rycee rycee closed this Nov 10, 2017
@rycee rycee deleted the bump/electron-cash branch November 10, 2017 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants