Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newsboat: init at 2.10.1 #31719

Closed
wants to merge 74 commits into from
Closed

newsboat: init at 2.10.1 #31719

wants to merge 74 commits into from

Conversation

tasmo
Copy link
Contributor

@tasmo tasmo commented Nov 15, 2017

A fork of Newsbeuter, an RSS/Atom feed reader for the text console.

Motivation for this change

Because Newsbeuter is not actively maintained anymore.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@teto
Copy link
Member

teto commented Nov 17, 2017

the program works for me but the manpage doesn t seem to be installed.

@tasmo
Copy link
Contributor Author

tasmo commented Nov 17, 2017

@teto Thank you for commenting! I will look into it asap.

Nick Novitski and others added 11 commits November 18, 2017 14:42
Since ssh-dss is no longer supported by default, users relying on those
keys for their login may be locked out. They should ideally use stronger
keys, but adding the support for ssh-dss back in can also be done
through extraConfig.
The bash module currently sets the `/etc/inputrc` unconditionally,
which prevents easy user override. This commit lowers the priority of
the setting to "option default" level, which allows a user to override
the value using either

    environment.etc."inputrc".text = …

or

    environment.etc."inputrc".source = …
wrapFirefox: make overridable, support browserpass
hedning and others added 16 commits November 21, 2017 14:01
Various improvements including attribute completion when supplying a cached
url as a repo.
Various improvements and bugfixes.
nodePackages.coinmon: init at 0.0.6
nix-zsh-completions: 0.3.3 -> 0.3.5, nix-bash-completions: 0.4 -> 0.5
With this disabled, cameras would not get a `/dev/mediaX` entry matching
the `/dev/videoX` which broke any application (e.g: `uvcdynctrl -l`,
`media-ctl -p`) depending on this interface.
They are invalid for our OpenSSH
From the changelog:

```
Intel Processor Microcode Package for Linux
20171117 Release

-- New Platforms --
CFL U0 (06-9e-0a:22) 70
CFL B0 (06-9e-0b:2) 72
SKX H0 (06-55-04:b7) 2000035
GLK B0 (06-7a-01:1) 1e
APL Bx (06-5c-09:3) 2c
-- Updates --
KBL Y0 (06-8e-0a:c0) 66->70
-- Removed files --
SKX H0 (06-55-04:97) 2000022
```
microcodeIntel: 20170707 -> 20171117
@nicknovitski
Copy link
Contributor

nicknovitski commented Nov 23, 2017

Great minds think alike 😄 . Feel free to include me as a maintainer.

Notes from my PR:

  • src: use fetchzip instead of fetchurl, because I ran into bizarre nix-store problems that I believe were caused by the zip file's hash changing..but if you haven't run into it maybe that was just a mistake on my part.
  • Makefile: change a2x to a2x --no-xmllint, because the linter fails when it can't download the document's DTD in the build environment. The make target silently swallows that error so the build succeeds but the man pages are nowhere to be found.
  • config.sh: change ncurses5.4 to ncurses, because on darwin the former name is hard-coded.
postPatch = ''
    substituteInPlace config.sh \
      --replace "ncurses5.4" "ncurses"
    substituteInPlace ./Makefile \
      --replace "a2x" "${asciidoc}/bin/a2x --no-xmllint"
  '';
  • postInstall: On all platforms (not just on darwin, like my PR mistakenly had), cp -r $src/contrib $out. There's color themes and scripts in that folder which I want to use, so I want the folder to be in my profile.

@FRidh FRidh removed their request for review November 23, 2017 08:05
@tasmo tasmo changed the title newsboat: init at r2.10.1 newsboat: init at 2.10.1 Nov 24, 2017
still does not compile man pages
@tasmo
Copy link
Contributor Author

tasmo commented Nov 24, 2017

@nicknovitski I still cannot get man pages compiled. Do you have any clue?

@nicknovitski
Copy link
Contributor

@tasmo If you look at newsboat's Makefile, you can see a bunch of lines ending in || true, mostly to do with building and installing docs. That swallows any errors on the line. I'd suggest adding another substitution to replace them with an empty string. That way the errors will become visible and give you more information.

Also you seem to have accidentally pulled in a bunch of other people's commits; be sure to rebase and get rid of those.

@dotlambda dotlambda mentioned this pull request Jan 5, 2018
8 tasks
@dotlambda
Copy link
Member

@tasmo Please close this one.

@tasmo
Copy link
Contributor Author

tasmo commented Jan 22, 2018

Thank you @dotlambda and @Mic92!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet