Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hwinfo: 21.38 -> 21.50 #31716

Closed
wants to merge 2 commits into from
Closed

hwinfo: 21.38 -> 21.50 #31716

wants to merge 2 commits into from

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Nov 15, 2017 •
edited

Motivation for this change

Update hwinfo and its libx86emu dependency to latest stable releases
Also fixed the pkgconfig .pc file of hwinfo (prefix was wrong)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@c0bw3b
Copy link
Contributor Author

c0bw3b commented Nov 15, 2017 

$ ./result/bin/hwinfo --version
21.50

$ ./result/bin/hwinfo --short
cpu:                                                            
                       Intel(R) Core(TM) i7-4790S CPU @ 3.20GHz, 3200 MHz
                       Intel(R) Core(TM) i7-4790S CPU @ 3.20GHz, 3200 MHz
                       Intel(R) Core(TM) i7-4790S CPU @ 3.20GHz, 3200 MHz
                       Intel(R) Core(TM) i7-4790S CPU @ 3.20GHz, 3200 MHz
keyboard:
[...]

@orivej
Copy link
Contributor

orivej commented Nov 15, 2017

/cc maintainer @bobvanderlinden

orivej
orivej approved these changes Nov 15, 2017
View reviewed changes
Copy link
Contributor

@orivej orivej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re. DESTDIR=$(out)" "LIBDIR=/lib: technically this is a lie — our DESTDIR is empty and LIBDIR is ${out}/lib (this is usually achieved by setting PREFIX=$(out)) — but if the application works anyway, and since you did not write this, this is good to go.

@bjornfor
Copy link
Contributor

Applied to master (7a32e68, 0768420). Thanks!

@bjornfor bjornfor closed this Nov 15, 2017
@c0bw3b c0bw3b deleted the pkg/hwinfo branch November 15, 2017 22:02
@orivej
Copy link
Contributor

orivej commented Nov 15, 2017

@bjornfor Did you not merge this because you've added a comment #enableParallelBuilding = true;? Does this mean that hwinfo fails to build in parallel?

@c0bw3b
Copy link
Contributor Author

c0bw3b commented Nov 15, 2017 •
edited

I had that comment in the first place and then removed entirely it in a second push.
And it was commented because I did encounter failure to build hwinfo when trying to enable parallel building

@bjornfor
Copy link
Contributor

I didn't change the PR, I rebased locally without doing any changes. I didn't notice to the commented line :-/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orivej orivej orivej approved these changes

Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@c0bw3b @orivej @bjornfor @GrahamcOfBorg